Skip to contentSkip to conversation

staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

PATCH New Ben Evans 3 participants 4 messages Jul 7, 2015 – Jul 8, 2015 Staging

lore
Share & tools
lore

Ben Evans

author
#0 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction. This flag is no longer used.

Signed-off-by Aurelien Degremont <[email protected]>

Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195

Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>
---
 .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1
index 4d72d6e..bea70cb 100644
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
 	MDS_PERM_BYPASS		= 1 << 3,
 	MDS_SOM			= 1 << 4,
 	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
 	MDS_KEEP_ORPHAN		= 1 << 7,
 	MDS_RECOV_OPEN		= 1 << 8,
 	MDS_DATA_MODIFIED	= 1 << 9,
Signature · 1 line
1.6.5.6
#1 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

Unless there is code in this client that explicitly prevents it from connecting with a pre-2.4.0 server, perhaps this flag should not be removed.

Chris

Quoted 30 lines · Ben Evans

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction. This flag is no longer used.

Signed-off-by Aurelien Degremont <[email protected]>

Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195

Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>
---
  .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1
index 4d72d6e..bea70cb 100644
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
  	MDS_PERM_BYPASS		= 1 << 3,
  	MDS_SOM			= 1 << 4,
  	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
  	MDS_KEEP_ORPHAN		= 1 << 7,
  	MDS_RECOV_OPEN		= 1 << 8,
  	MDS_DATA_MODIFIED	= 1 << 9,
#2 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

The flag is no longer used in the code so there is no value to keep it around. It was only ever used for SOM, which was deleted and never supported.

Cheers, Andreas

Quoted 41 lines · Christopher J. Morrone

Unless there is code in this client that explicitly prevents it from connecting with a pre-2.4.0 server, perhaps this flag should not be removed.

Chris

Quoted 22 lines · Ben Evans

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction. This flag is no longer used.

Signed-off-by Aurelien Degremont <[email protected]>

Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195

Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>
---
 .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +0 -0
index 4d72d6e..bea70cb 100644

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h enum mds_op_bias { · line 2396

Quoted 8 lines
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
     MDS_PERM_BYPASS        = 1 << 3,
     MDS_SOM            = 1 << 4,
     MDS_QUOTA_IGNORE    = 1 << 5,
-    MDS_CLOSE_CLEANUP    = 1 << 6,
+    /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
     MDS_KEEP_ORPHAN        = 1 << 7,
     MDS_RECOV_OPEN        = 1 << 8,
     MDS_DATA_MODIFIED    = 1 << 9,

_______________________________________________
lustre-devel mailing list
lustre-devel at lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org

#3 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

In reply to Ben Evans

The patch looks good at this point. Now you need to also sent it to Greg KH and the other staging lists.

Cheers, Andreas

Quoted 38 lines · Ben Evans

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction. This flag is no longer used.

Signed-off-by Aurelien Degremont <[email protected]>

Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195

Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>

---
.../lustre/lustre/include/lustre/lustre_idl.h | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1
index 4d72d6e..bea70cb 100644
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
   MDS_PERM_BYPASS        = 1 << 3,
   MDS_SOM            = 1 << 4,
   MDS_QUOTA_IGNORE    = 1 << 5,
-    MDS_CLOSE_CLEANUP    = 1 << 6,
+    /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
   MDS_KEEP_ORPHAN        = 1 << 7,
   MDS_RECOV_OPEN        = 1 << 8,
   MDS_DATA_MODIFIED    = 1 << 9,
Signature · 6 lines
1.6.5.6

_______________________________________________
lustre-devel mailing list
lustre-devel at lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org