Skip to contentSkip to conversation

ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()

PATCH In review Dan Carpenter 3 participants 3 messages Jul 9, 2015 – Jul 15, 2015

Subsystems (4)
Sound Kernel janitors ASoC Freescale SoC sound drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()

We need "i" to be signed or it leads to a forever loop in the error handling.

Fixes fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
Signed-off-by Dan Carpenter <[email protected]>
sound/soc/fsl/fsl_spdif.c +2 -1
index 3ee4539..7a92f30 100644
@@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
 	struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
 	struct platform_device *pdev = spdif_priv->pdev;
 	struct regmap *regmap = spdif_priv->regmap;
-	u32 scr, mask, i;
+	u32 scr, mask;
+	int i;
 	int ret;
 
 	/* Reset module and interrupts only for first initialization */
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

We need "i" to be signed or it leads to a forever loop in the error handling.

Fixes fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Nicolin Chen <[email protected]>

Thank you

Quoted 14 lines
sound/soc/fsl/fsl_spdif.c +2 -1
index 3ee4539..7a92f30 100644
@@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
 	struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
 	struct platform_device *pdev = spdif_priv->pdev;
 	struct regmap *regmap = spdif_priv->regmap;
-	u32 scr, mask, i;
+	u32 scr, mask;
+	int i;
 	int ret;
 
 	/* Reset module and interrupts only for first initialization */
maintainer
#2 lore raw

Applied "ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()" to the asoc tree

In reply to Dan Carpenter

The patch

ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 89e0e250f92b0b0233337043ddf76f261916036c Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Thu, 9 Jul 2015 11:21:03 +0300
Subject: [PATCH] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()

We need "i" to be signed or it leads to a forever loop in the error handling.

Fixes fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Nicolin Chen <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/fsl/fsl_spdif.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/fsl/fsl_spdif.c +2 -1
index 8e932219cb3a..851b83373d4c 100644
@@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
 	struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
 	struct platform_device *pdev = spdif_priv->pdev;
 	struct regmap *regmap = spdif_priv->regmap;
-	u32 scr, mask, i;
+	u32 scr, mask;
+	int i;
 	int ret;
 
 	/* Reset module and interrupts only for first initialization */
Signature · 1 line
2.1.4