Skip to contentSkip to conversation

netlink: reset skb->peeked when reuse orphan skb for next broadcast

PATCH In review Konstantin Khlebnikov 2 participants 2 messages Jul 10, 2015 – Jul 13, 2015

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Konstantin Khlebnikov

author
#0 lore raw

PATCH v2 1/1 netlink: reset skb->peeked when reuse orphan skb for next broadcast

This patch clears skb->peeked set by previous recipient of broadcast.

Signed-off-by Konstantin Khlebnikov <[email protected]>
Fixes add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")
---
 net/netlink/af_netlink.c |    1 +
 1 file changed, 1 insertion(+)
net/netlink/af_netlink.c +1 -0
index 921e0d8dfe3a..f4427f4bf223 100644
@@ -1967,6 +1967,7 @@ static void do_one_broadcast(struct sock *sk,
 			 * delivered to a previous socket.
 			 */
 			skb_orphan(p->skb2);
+			p->skb2->peeked = 0;
 		}
 	}
 	if (p->skb2 == NULL) {
#1 lore raw
Quoted 4 lines · Konstantin Khlebnikov

This patch clears skb->peeked set by previous recipient of broadcast.

Signed-off-by Konstantin Khlebnikov <[email protected]>
Fixes add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")

Per my earlier email, this patch is not needed if we fix the root cause.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt