net: stop endless flood about dst entry refcount underflow or overflow
Subsystems (2)
PATCH 1/1 net: stop endless flood about dst entry refcount underflow or overflow
Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2.
That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already fixed in upstream. Anyway flood of that warnings completely kills machine and makes further debugging impossible.
--- net/core/dst.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/core/dst.c +2 -1
@@ -284,7 +284,8 @@ void dst_release(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -WARN_ON (newrefcnt <0 ); +if (WARN (newrefcnt <0 ,"dst: %p refcnt: %d\n" , dst, newrefcnt)) +atomic_set (&dst->__refcnt,INT_MAX /2 );if (unlikely (dst->flags &DST_NOCACHE ) && !newrefcnt)call_rcu (&dst->rcu_head, dst_destroy_rcu); }
Quoted 18 lines · Konstantin Khlebnikov
Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2.
That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already fixed in upstream. Anyway flood of that warnings completely kills machine and makes further debugging impossible.
Signed-off-by Konstantin Khlebnikov <[email protected]>--- net/core/dst.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/core/dst.c +0
-0
net/core/dst.c void dst_release(struct dst_entry *dst) · line 291
Quoted 9 lines
net/core/dst.c +2
-1@@ -284,7 +284,8 @@ void dst_release(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -WARN_ON (newrefcnt <0 ); +if (WARN (newrefcnt <0 ,"dst: %p refcnt: %d\n" , dst, newrefcnt)) +atomic_set (&dst->__refcnt,INT_MAX /2 );if (unlikely (dst->flags &DST_NOCACHE ) && !newrefcnt)call_rcu (&dst->rcu_head, dst_destroy_rcu); }
WARN_ON_ONCE() if you want, but setting __refcnt like this is absolutely a dirty hack.
Quoted 21 lines · Eric Dumazet
Quoted 20 lines · Konstantin Khlebnikov
Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2.
That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already fixed in upstream. Anyway flood of that warnings completely kills machine and makes further debugging impossible.
Signed-off-by Konstantin Khlebnikov <[email protected]>--- net/core/dst.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/core/dst.c +0
-0@@ -284,7 +284,8 @@ void dst_release(struct dst_entry *dst)int newrefcnt;
Quoted 11 lines
net/core/dst.c void dst_release(struct dst_entry *dst) · line 291
Quoted 7 lines
net/core/dst.c +2
-1newrefcnt =atomic_dec_return (&dst->__refcnt); -WARN_ON (newrefcnt <0 ); +if (WARN (newrefcnt <0 ,"dst: %p refcnt: %d\n" , dst, newrefcnt)) +atomic_set (&dst->__refcnt,INT_MAX /2 );if (unlikely (dst->flags &DST_NOCACHE ) && !newrefcnt)call_rcu (&dst->rcu_head, dst_destroy_rcu); }
WARN_ON_ONCE()if you want, but setting__refcntlike this is absolutely a dirty hack.
Simple warn-once will hide a lot of information which could be useful. Also dst entry leak is better than freeing actually active entry.
Quoted 3 lines
Signature · 1 line
Konstantin
Quoted 2 lines · Konstantin Khlebnikov
Simple warn-once will hide a lot of information which could be useful. Also dst entry leak is better than freeing actually active entry.
Then BUG_ON() .
Really, we need to fix leaks, not brown paper them.
David Miller
maintainerFrom: Eric Dumazet <[email protected]>
Date: Tue, 14 Jul 2015 14:26:07 +0200
Quoted 8 lines · Konstantin Khlebnikov
Quoted 3 lines
Simple warn-once will hide a lot of information which could be useful. Also dst entry leak is better than freeing actually active entry.
Then
BUG_ON().Really, we need to fix leaks, not brown paper them.
No, killing the machine is not the answer.
If you want to rate limit this message, do it on a per-device basis, but without corrupting the netdev state in the process.