Skip to contentSkip to conversation

PCI / ACPI: Fix pci_acpi_optimize_delay() comment

PATCH Applied Srinidhi Kasagar 3 participants 3 messages Jul 15, 2015 – Jul 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI / ACPI: Fix pci_acpi_optimize_delay() comment

The function takes ACPI handle, not the device itself. Fix the comment

---
Add this as part of your trivial commenting fixes patch series

 drivers/pci/pci-acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-acpi.c +1 -1
index 6f6f175f51f7..d2e2bf4ef0a4 100644
@@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
 /**
  * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
  * @pdev: the PCI device whose delay is to be updated
- * @adev: the companion ACPI device of this PCI device
+ * @handle: ACPI handle of this device
  *
  * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
  * control method of either the device itself or the PCI host bridge.
Signature · 4 lines
1.7.9.5


-- 
maintainer Applied
#1 lore raw

[+cc Aaron]

Quoted 4 lines · Srinidhi Kasagar

The function takes ACPI handle, not the device itself. Fix the comment

Applied to pci/misc for v4.3, thanks!

Quoted 24 lines

---
Add this as part of your trivial commenting fixes patch series

 drivers/pci/pci-acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-acpi.c +1 -1
index 6f6f175f51f7..d2e2bf4ef0a4 100644
@@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
 /**
  * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
  * @pdev: the PCI device whose delay is to be updated
- * @adev: the companion ACPI device of this PCI device
+ * @handle: ACPI handle of this device
  *
  * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
  * control method of either the device itself or the PCI host bridge.
Signature · 4 lines
1.7.9.5


-- 
#2 lore raw
Quoted 5 lines · Bjorn Helgaas

[+cc Aaron]

Quoted 2 lines · Srinidhi Kasagar

The function takes ACPI handle, not the device itself. Fix the comment

I must have overlooked the comment while changing the function prototype, thanks for the fix!

Regards,
Aaron

Quoted 29 lines
Quoted 2 lines

Applied to pci/misc for v4.3, thanks!

Quoted 24 lines

---
Add this as part of your trivial commenting fixes patch series

 drivers/pci/pci-acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-acpi.c +1 -1
index 6f6f175f51f7..d2e2bf4ef0a4 100644
@@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
 /**
  * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
  * @pdev: the PCI device whose delay is to be updated
- * @adev: the companion ACPI device of this PCI device
+ * @handle: ACPI handle of this device
  *
  * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
  * control method of either the device itself or the PCI host bridge.
Signature · 4 lines
1.7.9.5


--