Skip to contentSkip to conversation

What can I do if I sent a wrong patch?

DISCUSSION Navy 3 participants 3 messages Jul 19, 2015

lore
Share & tools
lore

Navy

author
#0 lore raw

Hello,
A mistake was found after I sent the patch to mentors. What Can I do to make up the fault?

#1 lore raw
Quoted 4 lines · Navy

Hello,

A mistake was found after I sent the patch to mentors. What Can I do to make up the fault?

first, if they're truly mentors, they should check the patch
themselves and catch the error. otherwise, they're not really doing their job as "mentors."

second, you need to self-examine what you failed to do properly to
have sent in a bad patch.

i doubt you've done any real harm; the linux kernel has lots of
checking up the hierarchy so that a truly damaging patch is rarely going to get into the source tree.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#2 lore raw
Quoted 7 lines · Robert P. J. Day
Quoted 4 lines · Navy

Hello,

A mistake was found after I sent the patch to mentors. What Can I do to make up the fault?

Quoted 6 lines

first, if they're truly mentors, they should check the patch
themselves and catch the error. otherwise, they're not really doing their job as "mentors."

second, you need to self-examine what you failed to do properly to
have sent in a bad patch.

third, send out a follow-up email informing people that you found a mistake with your patch.

People appreciate developers who take responsibility for their code, and work to fix it up after the fact.

Signature · 1 line
All rights reversed.