Skip to contentSkip to conversation

ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of()

PATCH In review Dan Carpenter 2 participants 2 messages Jul 21, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of()

There is a stray '!' which means the condition is never true.

Fixes f3bd847eb0a7 ('ASoC: sti: Add uniperipheral dai driver')
sound/soc/sti/sti_uniperif.c +1 -1
index 51f745c..dffabf3 100644
@@ -175,7 +175,7 @@ static int sti_uniperiph_cpu_dai_of(struct device_node *node,
 				     UNIPERIF_FIFO_DATA_OFFSET(uni);
 
 	uni->irq = platform_get_irq(priv->pdev, 0);
-	if (!uni->irq < 0) {
+	if (uni->irq < 0) {
 		dev_err(dev, "Failed to get IRQ resource");
 		return -ENXIO;
 	}
maintainer
#1 lore raw

Applied "ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of()" to the asoc tree

The patch

ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From a4642e99694a912b32952317e8f4c253ed6be4a9 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 21 Jul 2015 11:57:36 +0300
Subject: [PATCH] ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of()

There is a stray '!' which means the condition is never true.

Fixes f3bd847eb0a7 ('ASoC: sti: Add uniperipheral dai driver')
---
 sound/soc/sti/sti_uniperif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/sti_uniperif.c +1 -1
index 51f745c56c7f..dffabf3ba9fb 100644
@@ -175,7 +175,7 @@ static int sti_uniperiph_cpu_dai_of(struct device_node *node,
 				     UNIPERIF_FIFO_DATA_OFFSET(uni);
 
 	uni->irq = platform_get_irq(priv->pdev, 0);
-	if (!uni->irq < 0) {
+	if (uni->irq < 0) {
 		dev_err(dev, "Failed to get IRQ resource");
 		return -ENXIO;
 	}
Signature · 1 line
2.1.4