Skip to contentSkip to conversation

via rhine build regression for arch/sh

DISCUSSION Paul Gortmaker 2 participants 2 messages Jul 22, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

The builds of arch/sh are failing in linux-next with:

drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-function-declaration] drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration of function 'pci_iounmap' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/ethernet/via/via-rhine.o] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/12468878/

It either is the one line change in:

commit b7d3282a245f44286b88e436b1d08c518cdf4569

Author: Antonio Borneo <[email protected]>
Date:   Wed Jun 17 19:42:31 2015 +0800

net: via/Kconfig: replace USE_OF with OF_???

..or maybe it goes back to the original OF support patch:

commit 2d283862dc62daead9db0dc89cd0d0351e91f765

Author: Alexey Charkov <[email protected]>
Date:   Tue Apr 22 19:28:09 2014 +0400

net: via-rhine: add OF bus binding

I have not bisected to check which, but it seems likely that it is one of the above.

Paul.

#1 lore raw
Quoted 26 lines · Paul Gortmaker

The builds of arch/sh are failing in linux-next with:

drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-function-declaration] drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration of function 'pci_iounmap' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/ethernet/via/via-rhine.o] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/12468878/

It either is the one line change in:

commit b7d3282a245f44286b88e436b1d08c518cdf4569

Author: Antonio Borneo <[email protected]>
Date:   Wed Jun 17 19:42:31 2015 +0800

net: via/Kconfig: replace USE_OF with OF_???

..or maybe it goes back to the original OF support patch:

commit 2d283862dc62daead9db0dc89cd0d0351e91f765

Author: Alexey Charkov <[email protected]>
Date:   Tue Apr 22 19:28:09 2014 +0400
Quoted 8 lines

net: via-rhine: add OF bus binding

I have not bisected to check which, but it seems likely that it is one of the above.

Paul.

Hi Paul,

yes, I can reproduce it and depends on my patch.
I'm sending out a fix. Could you please check it?

Best Regards,
Antonio