blkcg: fix gendisk reference leak in blkg_conf_prep()
Subsystems (2)
Tejun Heo
maintainerPATCH 1/1 blkcg: fix gendisk reference leak in blkg_conf_prep()
When a blkcg configuration is targeted to a partition rather than a whole device, blkg_conf_prep fails with -EINVAL; unfortunately, it forgets to put the gendisk ref in that case. Fix it.
Signed-off-by Tejun Heo <[email protected]>
--- block/blk-cgroup.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
block/blk-cgroup.c +5 -1
@@ -791,8 +791,12 @@ int blkg_conf_prep(struct blkcg *blkcg,return -EINVAL ; disk =get_gendisk (MKDEV (major, minor), &part); -if (!disk || part) +if (!disk)return -EINVAL ; +if (part) { +put_disk (disk); +return -EINVAL ; + }rcu_read_lock ();spin_lock_irq (disk->queue->queue_lock);
Quoted 3 lines · Tejun Heo
When a blkcg configuration is targeted to a partition rather than a whole device,
blkg_conf_prepfails with-EINVAL; unfortunately, it forgets to put the gendisk ref in that case. Fix it.
Applied, thanks.
Signature · 1 line
Jens Axboe