scsi: fcoe: Convert use of __constant_htons to htons
Subsystems (2)
PATCH 1/1 scsi: fcoe: Convert use of __constant_htons to htons
In little endian cases, the macro htons unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. So, replace __constant_htons with htons with the goal of getting rid of the definition of __constant_htons completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_htons(x)
+ htons(x)
--- drivers/scsi/fcoe/fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/fcoe/fcoe.c +1 -1
@@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,* on the ethertype for the given device */ fcoe->fcoe_packet_type.func = fcoe_rcv; - fcoe->fcoe_packet_type.type =__constant_htons (ETH_P_FCOE ); + fcoe->fcoe_packet_type.type =htons (ETH_P_FCOE ); fcoe->fcoe_packet_type.dev = netdev;dev_add_pack (&fcoe->fcoe_packet_type);
Signature · 1 line
1.9.1
Quoted 23 lines · Vaishali Thakkar
In little endian cases, the macro htons unfolds to
__swab16which provides special case for constants. In big endian cases,__constant_htonsand htons expand directly to the same expression. So, replace__constant_htonswith htons with the goal of getting rid of the definition of__constant_htonscompletely.The semantic patch that performs this transformation is as follows:
@@expression x;@@
-
__constant_htons(x)
+ htons(x)Signed-off-by Vaishali Thakkar <[email protected]>--- drivers/scsi/fcoe/fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/fcoe/fcoe.c +0
-0
drivers/scsi/fcoe/fcoe.c static int fcoe_interface_setup(struct fcoe_interface *fcoe, · line 370
Quoted 8 lines
drivers/scsi/fcoe/fcoe.c +1
-1@@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,* on the ethertype for the given device */ fcoe->fcoe_packet_type.func = fcoe_rcv; - fcoe->fcoe_packet_type.type =__constant_htons (ETH_P_FCOE ); + fcoe->fcoe_packet_type.type =htons (ETH_P_FCOE ); fcoe->fcoe_packet_type.dev = netdev;dev_add_pack (&fcoe->fcoe_packet_type);