netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver

media Dan Carpenter 1 participant 1 message Aug 19, 2015 Media (V4L/DVB)

Share & tools

Dan Carpenter

author

2015-08-19 08:01 UTC #0 lore raw

Hello Kozlov Sergey,

The patch 52b1eaf4c59a: "[media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver" from Jul 28, 2015, leads to the following static checker warning:

drivers/media/pci/netup_unidvb/netup_unidvb_spi.c:84 netup_spi_interrupt()
error: we previously assumed 'spi' could be null (see line 83)

drivers/media/pci/netup_unidvb/netup_unidvb_spi.c

    78  irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
    79  {
    80          u16 reg;
    81          unsigned long flags;
    82  
    83          if (!spi) {
                    ^^^^
    84                  dev_dbg(&spi->master->dev,
                                ^^^^^^^^^^^^^^^^^
    85                          "%s(): SPI not initialized\n", __func__);
    86                  return IRQ_NONE;
    87          }
    88          spin_lock_irqsave(&spi->lock, flags);