Skip to contentSkip to conversation

Aníbal Limón : systemd: Increase devices timeout in QEMU machines to avoid failures on serial-getty

oe-commits New Martin Jansa 1 participant 2 messages Sep 15, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 78 lines · On Sat, Aug 29, 2015 at 12:39:35PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 5196d7bacaef1076c361adaa2867be31759c1b52
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=5196d7bacaef1076c361adaa2867be31759c1b52
Author: Aníbal Limón <[email protected]>
Date:   Fri Aug 28 11:15:01 2015 -0500

systemd: Increase devices timeout in QEMU machines to avoid failures on serial-getty

Systemd serial-getty is failing because dev-tty ends with timeout, systemd uses a default timeout of 90 secs that it's reached on AB's production environment due to high I/O loads (nfs).

When use QEMU is used without KVM support, the machine code is executed by TCG (software code execution) that is dependent on devices layer and causes locks
between TCG/Devices increasing the machine code execution time [1].

QEMU don't support configuration of device timeout always uses a default one that is 90 secs, so the next patch increases the device timeout to 240 secs [2] in order give enough time to get devices ready. It ONLY applies on QEMU machines.

[YOCTO #8141]

[1] http://blog.vmsplice.net/2011/03/qemu-internals-overall-architecture-and.html
[2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8141#c10

---

 ....c-Change-the-default-device-timeout-to-2.patch | 31 ++++++++++++++++++++++
 meta/recipes-core/systemd/systemd_219.bb           |  1 +
 2 files changed, 32 insertions(+)
meta/recipes-core/systemd/systemd/qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch new file +31 -0
new file mode 100644
index 0000000..c7e1711
@@ -0,0 +1,31 @@
+Upstream-Status: Inappropriate [Specific case QEMU/AB]
+
+From 7b8c4e0a67a79a75e1bd77df3a452a5497322108 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <[email protected]>
+Date: Thu, 27 Aug 2015 17:58:26 -0500
+Subject: [PATCH] core/device.c: Change the default device timeout to 240 sec.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Signed-off-by: Aníbal Limón <[email protected]>
+---
+ src/core/device.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/core/device.c b/src/core/device.c
+index e7efcf0..4ed8f08 100644
+--- a/src/core/device.c
++++ b/src/core/device.c
+@@ -110,7 +110,7 @@ static void device_init(Unit *u) {
+          * indefinitely for plugged in devices, something which cannot
+          * happen for the other units since their operations time out
+          * anyway. */
+-        u->job_timeout = u->manager->default_timeout_start_usec;
++        u->job_timeout = (240 * USEC_PER_SEC);
+ 
+         u->ignore_on_isolate = true;
+         u->ignore_on_snapshot = true;
+-- 
+1.9.1
+
meta/recipes-core/systemd/systemd_219.bb +0 -0
index e187cea..2326753 100644

meta/recipes-core/systemd/systemd_219.bb SRC_URI = "git://github.com/systemd/systemd-stable;branch=v219-stable;protocol=g · line 53

Quoted 4 lines
meta/recipes-core/systemd/systemd_219.bb +1 -0
@@ -50,6 +50,7 @@ SRC_URI = "git://github.com/systemd/systemd-stable;branch=v219-stable;protocol=g
            file://init \
            file://run-ptest \
           "
+SRC_URI_append_qemuall = "file://qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch"

Most appends need to start with leading space, this breaks all build where SRC_URI doesn't end with a space already (e.g. if some layer appends something to SRC_URI).

I'll send patch, but be more careful next time.

Quoted 9 lines
meta/recipes-core/systemd/systemd_219.bb +0 -0
 S = "${WORKDIR}/git"
 
 
Signature · 4 lines
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw

PATCH 1/1 systemd: fix missing space in SRC_URI append

* it was introduced in:
commit 5196d7bacaef1076c361adaa2867be31759c1b52
Author: Aníbal Limón <[email protected]>
Date: Fri Aug 28 11:15:01 2015 -0500
Subject: systemd: Increase devices timeout in QEMU machines to avoid failures on serial-getty

---
 meta/recipes-core/systemd/systemd_225.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_225.bb +1 -1
index 6ac99cd..f7d4c7d 100644
@@ -46,7 +46,7 @@ SRC_URI = "git://github.com/systemd/systemd.git;protocol=git \
            file://init \
            file://run-ptest \
           "
-SRC_URI_append_qemuall = "file://qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch"
+SRC_URI_append_qemuall = " file://qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch"
 
 S = "${WORKDIR}/git"
 
Signature · 1 line
2.5.1