btrfs: use a single if() statement for one outcome in get_block_rsv()
PATCH 1/1 btrfs: use a single if() statement for one outcome in get_block_rsv()
Rather than have three separate if() statements for the same outcome we should just OR them together in the same if() statement.
Signed-off-by Alexandru Moise <[email protected]>
--- fs/btrfs/extent-tree.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
fs/btrfs/extent-tree.c +3 -7
@@ -4890,13 +4890,9 @@ static struct btrfs_block_rsv *get_block_rsv( {struct btrfs_block_rsv *block_rsv =NULL ; -if (test_bit (BTRFS_ROOT_REF_COWS , &root->state)) - block_rsv = trans->block_rsv; - -if (root == root->fs_info->csum_root && trans->adding_csums) - block_rsv = trans->block_rsv; - -if (root == root->fs_info->uuid_root) +if (test_bit (BTRFS_ROOT_REF_COWS , &root->state) || + (root == root->fs_info->csum_root && trans->adding_csums) || + (root == root->fs_info->uuid_root)) block_rsv = trans->block_rsv;if (!block_rsv)
Signature · 1 line
2.5.1
Quoted 4 lines · Alexandru Moise
Rather than have three separate
if()statements for the same outcome we should just OR them together in the sameif()statement.Signed-off-by Alexandru Moise <[email protected]>
Reviewed-by David Sterba <[email protected]>