Skip to contentSkip to conversation

hw_random: octeon-rng: Use devm_hwrng_register

PATCH In review Vaishali Thakkar 2 participants 2 messages Sep 10, 2015 – Sep 18, 2015

Subsystems (2)
Crypto API Hardware random number generator core
lore
Share & tools
lore

Vaishali Thakkar

author
#0 lore raw

PATCH 1/1 hw_random: octeon-rng: Use devm_hwrng_register

Use resource managed function devm_hwrng_register instead of hwrng_register to make the error-path simpler. Also, remove octeon_rng_remove as it is now redundant.

Signed-off-by Vaishali Thakkar <[email protected]>
---
 drivers/char/hw_random/octeon-rng.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/char/hw_random/octeon-rng.c +1 -11
index 6234a4a..8c78aa0 100644
@@ -96,7 +96,7 @@ static int octeon_rng_probe(struct platform_device *pdev)
 	rng->ops = ops;
 
 	platform_set_drvdata(pdev, &rng->ops);
-	ret = hwrng_register(&rng->ops);
+	ret = devm_hwrng_register(&pdev->dev, &rng->ops);
 	if (ret)
 		return -ENOENT;
 

@@ -105,21 +105,11 @@ static int octeon_rng_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int octeon_rng_remove(struct platform_device *pdev)
-{
-	struct hwrng *rng = platform_get_drvdata(pdev);
-
-	hwrng_unregister(rng);
-
-	return 0;
-}
-
 static struct platform_driver octeon_rng_driver = {
 	.driver = {
 		.name		= "octeon_rng",
 	},
 	.probe		= octeon_rng_probe,
-	.remove		= octeon_rng_remove,
 };
 
 module_platform_driver(octeon_rng_driver);
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 5 lines · Vaishali Thakkar

Use resource managed function devm_hwrng_register instead of hwrng_register to make the error-path simpler. Also, remove octeon_rng_remove as it is now redundant.

Signed-off-by Vaishali Thakkar <[email protected]>

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt