Skip to contentSkip to conversation

power: qcom_smbb: test the correct variable

PATCH In review Dan Carpenter 3 participants 3 messages Sep 24, 2015

Subsystems (2)
Arm Qualcomm mailing list Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 power: qcom_smbb: test the correct variable

"state" is a bool so it's never less than zero. The intent was to test "ret" instead.

Fixes 56d7df8716b2 ('power: Add Qualcomm SMBB driver')
Signed-off-by Dan Carpenter <[email protected]>
drivers/power/qcom_smbb.c +1 -1
index 0dabfe8..5eb1e9e 100644
@@ -351,7 +351,7 @@ static void smbb_set_line_flag(struct smbb_charger *chg, int irq, int flag)
 	int ret;
 
 	ret = irq_get_irqchip_state(irq, IRQCHIP_STATE_LINE_LEVEL, &state);
-	if (state < 0) {
+	if (ret < 0) {
 		dev_err(chg->dev, "failed to read irq line\n");
 		return;
 	}
#1 lore raw
Quoted 11 lines · Dan Carpenter

"state" is a bool so it's never less than zero. The intent was to test "ret" instead.

Fixes 56d7df8716b2 ('power: Add Qualcomm SMBB driver')
Signed-off-by Dan Carpenter <[email protected]>
drivers/power/qcom_smbb.c +0 -0
index 0dabfe8..5eb1e9e 100644

drivers/power/qcom_smbb.c static void smbb_set_line_flag(struct smbb_charger *chg, int irq, int flag) · line 357

Quoted 8 lines
drivers/power/qcom_smbb.c +1 -1
@@ -351,7 +351,7 @@ static void smbb_set_line_flag(struct smbb_charger *chg, int irq, int flag)
 	int ret;
 
 	ret = irq_get_irqchip_state(irq, IRQCHIP_STATE_LINE_LEVEL, &state);
-	if (state < 0) {
+	if (ret < 0) {
 		dev_err(chg->dev, "failed to read irq line\n");
 		return;
 	}

Hrm. This must be a leftover from when this was using Bjorn's irq_read_line(). Thanks!

I guess you caught this with smatch? Neither sparse nor gcc give me a warning here, which is disappointing.

-Courtney