Skip to contentSkip to conversation

watchdog: iTCO_wdt: Fix unmet dependency in select

PATCH In review Jean Delvare 4 participants 4 messages Sep 25, 2015 2 messages not in the archive

Subsystems (2)
I2C subsystem host drivers Watchdog device drivers
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 watchdog: iTCO_wdt: Fix unmet dependency in select

ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.) This can result in link-time failures:

drivers/built-in.o: In function `i801_remove':
i2c-i801.c:(.text+0x1a6126): undefined reference to i2c_del_adapter' drivers/built-in.o: In function dmi_check_onboard_devices':
i2c-i801.c:(.text+0x1a7531): undefined reference to i2c_new_device' drivers/built-in.o: In function i801_probe':
i2c-i801.c:(.text+0x1a7aa8): undefined reference to i2c_add_adapter' i2c-i801.c:(.text+0x1a7e14): undefined reference to i2c_new_device'

So we must select I2C as well.

Reported-by Jim Davis <[email protected]>
Signed-off-by Jean Delvare <[email protected]>
Fixes 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint")
Cc Matt Fleming <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Lee Jones <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -0
@@ -818,6 +818,7 @@ config ITCO_WDT
 	depends on (X86 || IA64) && PCI
 	select WATCHDOG_CORE
 	select LPC_ICH if !EXPERT
+	select I2C if !EXPERT
 	select I2C_I801 if !EXPERT
 	---help---
 	  Hardware driver for the intel TCO timer based watchdog devices.
Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer
#1 lore raw
Quoted 29 lines · Jean Delvare

ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.) This can result in link-time failures:

drivers/built-in.o: In function `i801_remove':
i2c-i801.c:(.text+0x1a6126): undefined reference to i2c_del_adapter' drivers/built-in.o: In function dmi_check_onboard_devices':
i2c-i801.c:(.text+0x1a7531): undefined reference to i2c_new_device' drivers/built-in.o: In function i801_probe':
i2c-i801.c:(.text+0x1a7aa8): undefined reference to i2c_add_adapter' i2c-i801.c:(.text+0x1a7e14): undefined reference to i2c_new_device'

So we must select I2C as well.

Reported-by Jim Davis <[email protected]>
Signed-off-by Jean Delvare <[email protected]>
Fixes 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint")
Cc Matt Fleming <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Lee Jones <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
  drivers/watchdog/Kconfig |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/Kconfig config ITCO_WDT · line 824

Quoted 7 lines
drivers/watchdog/Kconfig +1 -0
@@ -818,6 +818,7 @@ config ITCO_WDT
  	depends on (X86 || IA64) && PCI
  	select WATCHDOG_CORE
  	select LPC_ICH if !EXPERT
+	select I2C if !EXPERT
  	select I2C_I801 if !EXPERT
  	---help---
  	  Hardware driver for the intel TCO timer based watchdog devices.

I had fixed the problem differently, similar to other drivers.

http://patchwork.roeck-us.net/patch/239/

Waiting for Wim to apply it.

Guenter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi Guenter,

Quoted 40 lines · Guenter Roeck
Quoted 29 lines · Jean Delvare

ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.) This can result in link-time failures:

drivers/built-in.o: In function `i801_remove':
i2c-i801.c:(.text+0x1a6126): undefined reference to i2c_del_adapter' drivers/built-in.o: In function dmi_check_onboard_devices':
i2c-i801.c:(.text+0x1a7531): undefined reference to i2c_new_device' drivers/built-in.o: In function i801_probe':
i2c-i801.c:(.text+0x1a7aa8): undefined reference to i2c_add_adapter' i2c-i801.c:(.text+0x1a7e14): undefined reference to i2c_new_device'

So we must select I2C as well.

Reported-by Jim Davis <[email protected]>
Signed-off-by Jean Delvare <[email protected]>
Fixes 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint")
Cc Matt Fleming <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Lee Jones <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
  drivers/watchdog/Kconfig |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/Kconfig config ITCO_WDT · line 824

Quoted 7 lines
drivers/watchdog/Kconfig +1 -0
@@ -818,6 +818,7 @@ config ITCO_WDT
  	depends on (X86 || IA64) && PCI
  	select WATCHDOG_CORE
  	select LPC_ICH if !EXPERT
+	select I2C if !EXPERT
  	select I2C_I801 if !EXPERT
  	---help---
  	  Hardware driver for the intel TCO timer based watchdog devices.

I had fixed the problem differently, similar to other drivers.

Quoted 1 line

http://patchwork.roeck-us.net/patch/239/

404 Not Found?

Quoted 1 line

Waiting for Wim to apply it.

Signature · 7 lines
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1443189749.4919.2.camel-H7Kp9ZFCxt/[email protected]

#5 lore raw
Quoted 43 lines · Jean Delvare

Hi Guenter,

Quoted 40 lines · Guenter Roeck
Quoted 29 lines · Jean Delvare

ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.) This can result in link-time failures:

drivers/built-in.o: In function `i801_remove':
i2c-i801.c:(.text+0x1a6126): undefined reference to i2c_del_adapter' drivers/built-in.o: In function dmi_check_onboard_devices':
i2c-i801.c:(.text+0x1a7531): undefined reference to i2c_new_device' drivers/built-in.o: In function i801_probe':
i2c-i801.c:(.text+0x1a7aa8): undefined reference to i2c_add_adapter' i2c-i801.c:(.text+0x1a7e14): undefined reference to i2c_new_device'

So we must select I2C as well.

Reported-by Jim Davis <[email protected]>
Signed-off-by Jean Delvare <[email protected]>
Fixes 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint")
Cc Matt Fleming <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Lee Jones <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
   drivers/watchdog/Kconfig |    2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/Kconfig config ITCO_WDT · line 824

Quoted 7 lines
drivers/watchdog/Kconfig +1 -0
@@ -818,6 +818,7 @@ config ITCO_WDT
   	depends on (X86 || IA64) && PCI
   	select WATCHDOG_CORE
   	select LPC_ICH if !EXPERT
+	select I2C if !EXPERT
   	select I2C_I801 if !EXPERT
   	---help---
   	  Hardware driver for the intel TCO timer based watchdog devices.

I had fixed the problem differently, similar to other drivers.

Quoted 4 lines
Quoted 1 line

http://patchwork.roeck-us.net/patch/239/

404 Not Found?

Interesting. WFM. Maybe I don't publish it to the outside world. Here is a different link:

https://lkml.org/lkml/2015/9/11/343

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html