Skip to contentSkip to conversation

Staging: sm750fb: ddk750_dvi: Fixed character limit warning

PATCH In review Shivani Bhardwaj 2 participants 4 messages Oct 8, 2015

Subsystems (2)
Staging Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Shivani Bhardwaj

author
#0 lore raw

PATCH 1/1 Staging: sm750fb: ddk750_dvi: Fixed character limit warning

Fixed the warning - line over 80 characters generated by checkpatch by breaking the line at appropriate places so that the code looks more readable and good.

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +4 -3
index a7a2351..382b515 100644
@@ -46,9 +46,10 @@ int dviInit(
 
 	pCurrentDviCtrl = g_dcftSupportedDviController;
 	if (pCurrentDviCtrl->pfnInit != NULL) {
-		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
-						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
-						pllFilterEnable, pllFilterValue);
+		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
+			dualEdgeClkSelect, hsyncEnable, vsyncEnable,
+			deskewEnable, deskewSetting, continuousSyncEnable,
+					pllFilterEnable, pllFilterValue);
 	}
 	return -1; /* error */
 }
Signature · 1 line
2.1.0
#1 lore raw
Quoted 14 lines · Shivani Bhardwaj

Fixed the warning - line over 80 characters generated by checkpatch by breaking the line at appropriate places so that the code looks more readable and good.

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +0 -0
index a7a2351..382b515 100644

drivers/staging/sm750fb/ddk750_dvi.c int dviInit( · line 52

Quoted 10 lines
drivers/staging/sm750fb/ddk750_dvi.c +4 -3
@@ -46,9 +46,10 @@ int dviInit(
 
 	pCurrentDviCtrl = g_dcftSupportedDviController;
 	if (pCurrentDviCtrl->pfnInit != NULL) {
-		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
-						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
-						pllFilterEnable, pllFilterValue);
+		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
+			dualEdgeClkSelect, hsyncEnable, vsyncEnable,
+			deskewEnable, deskewSetting, continuousSyncEnable,
+					pllFilterEnable, pllFilterValue);

It looks like the arguments are not all lined up - the last ones are more indented than the others. The real problem would be the ariable names...

julia

Quoted 13 lines
drivers/staging/sm750fb/ddk750_dvi.c +0 -1
 	}
 	return -1; /* error */
 }
--

2.1.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

author
#2 lore raw
Quoted 30 lines · Julia Lawall
Quoted 14 lines · Shivani Bhardwaj

Fixed the warning - line over 80 characters generated by checkpatch by breaking the line at appropriate places so that the code looks more readable and good.

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +0 -0
index a7a2351..382b515 100644

drivers/staging/sm750fb/ddk750_dvi.c int dviInit( · line 52

Quoted 10 lines
drivers/staging/sm750fb/ddk750_dvi.c +4 -3
@@ -46,9 +46,10 @@ int dviInit(
 
 	pCurrentDviCtrl = g_dcftSupportedDviController;
 	if (pCurrentDviCtrl->pfnInit != NULL) {
-		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
-						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
-						pllFilterEnable, pllFilterValue);
+		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
+			dualEdgeClkSelect, hsyncEnable, vsyncEnable,
+			deskewEnable, deskewSetting, continuousSyncEnable,
+					pllFilterEnable, pllFilterValue);

It looks like the arguments are not all lined up - the last ones are more indented than the others. The real problem would be the ariable names...

Quoted 2 lines

julia

So, should I indent the last line in accordance with the previous ones? Will that work fine? I'm sorry, I do not understand what would be the problem with variable names.

Thanks
Shivani

Quoted 13 lines
Quoted 13 lines
drivers/staging/sm750fb/ddk750_dvi.c +0 -1
 	}
 	return -1; /* error */
 }
--

2.1.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

#3 lore raw
Quoted 31 lines · Shivani Bhardwaj
Quoted 30 lines · Julia Lawall
Quoted 14 lines · Shivani Bhardwaj

Fixed the warning - line over 80 characters generated by checkpatch by breaking the line at appropriate places so that the code looks more readable and good.

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +0 -0
index a7a2351..382b515 100644

drivers/staging/sm750fb/ddk750_dvi.c int dviInit( · line 52

Quoted 10 lines
drivers/staging/sm750fb/ddk750_dvi.c +4 -3
@@ -46,9 +46,10 @@ int dviInit(
 
 	pCurrentDviCtrl = g_dcftSupportedDviController;
 	if (pCurrentDviCtrl->pfnInit != NULL) {
-		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
-						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
-						pllFilterEnable, pllFilterValue);
+		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
+			dualEdgeClkSelect, hsyncEnable, vsyncEnable,
+			deskewEnable, deskewSetting, continuousSyncEnable,
+					pllFilterEnable, pllFilterValue);

It looks like the arguments are not all lined up - the last ones are more indented than the others. The real problem would be the ariable names...

Quoted 6 lines
Quoted 2 lines

julia

So, should I indent the last line in accordance with the previous ones? Will that work fine? I'm sorry, I do not understand what would be the problem with variable names.

All the arguments should always be lined up in the same way.

The variable names are very long. If you look in the mainline kernel, the variable names are not so long, and camel case is not used. It's sort of orthogonal to the patch, except that if the variable names were not so long, the code might not have been over the 80 character limit.

julia

Quoted 25 lines

Thanks
Shivani

Quoted 6 lines
Quoted 6 lines
drivers/staging/sm750fb/ddk750_dvi.c +0 -1
 	}
 	return -1; /* error */
 }
--

2.1.0

Quoted 7 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008113944.GA5621%40ubuntu.
For more options, visit https://groups.google.com/d/optout.