Skip to contentSkip to conversation

Staging: sm750fb: ddk750_help: Included KERN_ facility level

PATCH In review Shivani Bhardwaj 2 participants 3 messages Oct 8, 2015 – Oct 9, 2015

Subsystems (2)
Staging Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Shivani Bhardwaj

author
#0 lore raw

PATCH 1/1 Staging: sm750fb: ddk750_help: Included KERN_ facility level

Fixed the warning : printk() should include KERN_ facility level generated by checkpatch by using the function pr_info() instead of printk().

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +1 -1
index 9637dd3..e72a29c 100644
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
 }
Signature · 1 line
2.1.0
maintainer
#1 lore raw
Quoted 14 lines · Shivani Bhardwaj

Fixed the warning : printk() should include KERN_ facility level generated by checkpatch by using the function pr_info() instead of printk().

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +0 -0
index 9637dd3..e72a29c 100644

drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 14

Quoted 5 lines
drivers/staging/sm750fb/ddk750_help.c +1 -1
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");

Can you use dev_info() here instead?

author
#2 lore raw
Quoted 10 lines · Greg KH
Quoted 9 lines · Shivani Bhardwaj

Fixed the warning : printk() should include KERN_ facility level generated by checkpatch by using the function pr_info() instead of printk().

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 14

Quoted 10 lines
drivers/staging/sm750fb/ddk750_help.c +1 -1
index 9637dd3..e72a29c 100644
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");

Can you use dev_info() here instead?

Yes, OK. I'm sending version 2. :)
Thank you