Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info

PATCH Superseded Shivani Bhardwaj 2 participants 3 messages Oct 9, 2015

Subsystems (2)

Staging Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Shivani Bhardwaj

author

2015-10-09 07:30 UTC #0 lore raw

PATCH v2 1/1 Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info

Replaced the function printk() with dev_info() to fix the warning generated by checkpatch : printk() should include KERN_ facility level.

Signed-off-by Shivani Bhardwaj <[email protected]>

---
Changes in v2:
- Replaced the function pr_info() with dev_info()

 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/sm750fb/ddk750_help.c +1 -1

index 9637dd3..d20cd92 100644
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");
 }

Signature · 1 line

2.1.0

Sudip Mukherjee

maintainer

2015-10-09 07:44 UTC #1 lore raw

Quoted 16 lines · Shivani Bhardwaj

Replaced the function printk() with dev_info() to fix the warning generated by checkpatch : printk() should include KERN_ facility level.
Signed-off-by Shivani Bhardwaj <[email protected]>
---
Changes in v2:
- Replaced the function pr_info() with dev_info()
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +0 -0
index 9637dd3..d20cd92 100644

drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 14

Quoted 5 lines

drivers/staging/sm750fb/ddk750_help.c +1 -1

@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");

Did you try to compile it?

regards
sudip

Shivani Bhardwaj

author

2015-10-09 13:59 UTC #2 lore raw

Quoted 25 lines · Sudip Mukherjee

Quoted 16 lines · Shivani Bhardwaj
Replaced the function printk() with dev_info() to fix the warning generated by checkpatch : printk() should include KERN_ facility level.
Signed-off-by Shivani Bhardwaj <[email protected]>
---
Changes in v2:
- Replaced the function pr_info() with dev_info()
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +0 -0
index 9637dd3..d20cd92 100644
drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 14
Quoted 5 lines
drivers/staging/sm750fb/ddk750_help.c +1 -1
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
      devId750 = devId;
      revId750 = revId;
      if (revId == 0xfe)
-             printk("found sm750le\n");
+             dev_info("found sm750le\n");
Did you try to compile it?

Quoted 2 lines

regards
sudip

No, I just checked it against checkpatch, I found out that I have used the function in wrong way and I am working on fixing that. Thank you!