Skip to contentSkip to conversation

Staging: vt6655: mac: Remove extra braces

PATCH In review Shivani Bhardwaj 2 participants 2 messages Oct 12, 2015 Staging

lore
Share & tools
lore

Shivani Bhardwaj

author
#0 lore raw

PATCH 1/1 Staging: vt6655: mac: Remove extra braces

Remove braces from an if block as it comprises of a single statement. Fix checkpatch warning: braces {} are not necessary for single statement blocks

Signed-off-by Shivani Bhardwaj <[email protected]>
---
 drivers/staging/vt6655/mac.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/vt6655/mac.c +1 -2
index 3dfd333..688c3be 100644
@@ -689,9 +689,8 @@ void MACvSetCurrAC0DescAddrEx(void __iomem *dwIoBase,
 		if (!(byData & DMACTL_RUN))
 			break;
 	}
-	if (ww == W_MAX_TIMEOUT) {
+	if (ww == W_MAX_TIMEOUT)
 		pr_debug(" DBG_PORT80(0x26)\n");
-	}
 	VNSvOutPortD(dwIoBase + MAC_REG_AC0DMAPTR, dwCurrDescAddr);
 	if (byOrgDMACtl & DMACTL_RUN)
 		VNSvOutPortB(dwIoBase + MAC_REG_AC0DMACTL, DMACTL_RUN);
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Shivani Bhardwaj

Remove braces from an if block as it comprises of a single statement. Fix checkpatch warning: braces {} are not necessary for single statement blocks

Signed-off-by Shivani Bhardwaj <[email protected]>
Reviewed-by Daniel Baluta <[email protected]>
Quoted 28 lines
---
 drivers/staging/vt6655/mac.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/vt6655/mac.c +1 -3
index 3dfd333..688c3be 100644
@@ -689,9 +689,8 @@ void MACvSetCurrAC0DescAddrEx(void __iomem *dwIoBase,
                if (!(byData & DMACTL_RUN))
                        break;
        }
-       if (ww == W_MAX_TIMEOUT) {
+       if (ww == W_MAX_TIMEOUT)
                pr_debug(" DBG_PORT80(0x26)\n");
-       }
        VNSvOutPortD(dwIoBase + MAC_REG_AC0DMAPTR, dwCurrDescAddr);
        if (byOrgDMACtl & DMACTL_RUN)
                VNSvOutPortB(dwIoBase + MAC_REG_AC0DMACTL, DMACTL_RUN);
--

2.1.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151012174415.GA48424%40ubuntu.
For more options, visit https://groups.google.com/d/optout.