Staging: rtl8723au: rtw_mlme_ext: Remove unnecessary test expression
PATCH v3 1/1 Staging: rtl8723au: rtw_mlme_ext: Remove unnecessary test expression
Logical and-ing of a struct and its member should be replaced by the member only as the struct has already been NULL tested before.
---
Changes in v3:
-Make commit message better.
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723au/core/rtw_mlme_ext.c +1 -1
@@ -1715,7 +1715,7 @@ OnAssocReq23a(struct rtw_adapter *padapter, struct recv_frame *precv_frame)spin_unlock_bh (&pstapriv->asoc_list_lock);/* now the station is qualified to join our BSS... */ -if (pstat && pstat->state &WIFI_FW_ASSOC_SUCCESS && +if (pstat->state &WIFI_FW_ASSOC_SUCCESS && status ==WLAN_STATUS_SUCCESS ) {/* 1 bss_cap_update & sta_info_update23a */ bss_cap_update_on_sta_join23a (padapter, pstat);
Signature · 1 line
2.1.0
Quoted 4 lines · Shivani Bhardwaj
Logical and-ing of a struct and its member should be replaced by the member only as the struct has already been NULL tested before.
Signed-off-by Shivani Bhardwaj <[email protected]>
Fair enough.
Quoted 29 lines
---
Changes in v3:
-Make commit message better.drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8723au/core/rtw_mlme_ext.c +1
-2@@ -1715,7 +1715,7 @@ OnAssocReq23a(struct rtw_adapter *padapter, struct recv_frame *precv_frame)spin_unlock_bh (&pstapriv->asoc_list_lock);/* now the station is qualified to join our BSS... */ -if (pstat && pstat->state &WIFI_FW_ASSOC_SUCCESS && +if (pstat->state &WIFI_FW_ASSOC_SUCCESS && status ==WLAN_STATUS_SUCCESS ) {/* 1 bss_cap_update & sta_info_update23a */ bss_cap_update_on_sta_join23a (padapter, pstat); --2.1.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151014101906.GA3935%40ubuntu.
For more options, visit https://groups.google.com/d/optout.