Skip to contentSkip to conversation

Staging: lustre: lproc_osc: Change the variable to be checked

PATCH Superseded Shivani Bhardwaj 1 participant 1 message Oct 15, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: lustre: lproc_osc: Change the variable to be checked

The variable rc is supposed to hold the value returned by function kstrtoul which can either be 0, -EINVAL (-22) or -ERANGE (-34). Therefore, the check must be performed on rc instead of val for error values. Also, rc can never be greater than 0.

---
 drivers/staging/lustre/lustre/osc/lproc_osc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/lustre/lustre/osc/lproc_osc.c +1 -3
index 053d508..cdc7f88 100644
@@ -61,9 +61,7 @@ static ssize_t active_store(struct kobject *kobj, struct attribute *attr,
 	unsigned long val;
 
 	rc = kstrtoul(buffer, 10, &val);
-	if (rc)
-		return rc;
-	if (val < 0 || val > 1)
+	if (rc < 0)
 		return -ERANGE;
 
 	/* opposite senses */
Signature · 1 line
2.1.0