Skip to contentSkip to conversation

Staging: lustre: lcommon_misc: Correct block comments

PATCH Superseded Shivani Bhardwaj 2 participants 3 messages Oct 18, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: lustre: lcommon_misc: Correct block comments

Alignment of block comments should be correct.
Fix checkpatch WARNING: Block comments use a trailing */ on a separate line

---
 drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/lclient/lcommon_misc.c +4 -2
index 8389a0e..d80bcedd 100644
@@ -48,7 +48,8 @@
 /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
  * us to make MDS RPCs with large enough reply buffers to hold the
  * maximum-sized (= maximum striped) EA and cookie without having to
- * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
+ * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
+ */
 int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 {
 	struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };
@@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 	cookiesize = stripes * sizeof(struct llog_cookie);
 
 	/* default cookiesize is 0 because from 2.4 server doesn't send
-	 * llog cookies to client. */
+	 * llog cookies to client.
+	 */
 	CDEBUG(D_HA,
 	       "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
 	       def_easize, easize, cookiesize);
Signature · 1 line
2.1.0
#1 lore raw
Quoted 24 lines · Shivani Bhardwaj

Alignment of block comments should be correct.
Fix checkpatch WARNING: Block comments use a trailing */ on a separate line

---
 drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/lclient/lcommon_misc.c +2 -1
index 8389a0e..d80bcedd 100644
@@ -48,7 +48,8 @@
 /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
  * us to make MDS RPCs with large enough reply buffers to hold the
  * maximum-sized (= maximum striped) EA and cookie without having to
- * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
+ * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
+ */
 int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 {
        struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };

drivers/staging/lustre/lustre/lclient/lcommon_misc.c int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp) · line 82

Quoted 9 lines
drivers/staging/lustre/lustre/lclient/lcommon_misc.c +2 -1
@@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
        cookiesize = stripes * sizeof(struct llog_cookie);
 
        /* default cookiesize is 0 because from 2.4 server doesn't send
-        * llog cookies to client. */
+        * llog cookies to client.
+        */
        CDEBUG(D_HA,
               "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
               def_easize, easize, cookiesize);

While at it please also add an empty comment line at the begining:

/*
* first text line
* ..
*/

Like here: http://lxr.free-electrons.com/source/Documentation/CodingStyle#L467

#2 lore raw
Quoted 37 lines · Daniel Baluta
Quoted 24 lines · Shivani Bhardwaj

Alignment of block comments should be correct.
Fix checkpatch WARNING: Block comments use a trailing */ on a separate line

---
 drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/lclient/lcommon_misc.c +2 -1
index 8389a0e..d80bcedd 100644
@@ -48,7 +48,8 @@
 /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
  * us to make MDS RPCs with large enough reply buffers to hold the
  * maximum-sized (= maximum striped) EA and cookie without having to
- * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
+ * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
+ */
 int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 {
        struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };

drivers/staging/lustre/lustre/lclient/lcommon_misc.c int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp) · line 82

Quoted 9 lines
drivers/staging/lustre/lustre/lclient/lcommon_misc.c +2 -1
@@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
        cookiesize = stripes * sizeof(struct llog_cookie);
 
        /* default cookiesize is 0 because from 2.4 server doesn't send
-        * llog cookies to client. */
+        * llog cookies to client.
+        */
        CDEBUG(D_HA,
               "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
               def_easize, easize, cookiesize);

While at it please also add an empty comment line at the begining:

Quoted 6 lines

/*
* first text line
* ..
*/

Like here: http://lxr.free-electrons.com/source/Documentation/CodingStyle#L467

All right. Thank you.