Bogus names on vmware

Quoted 2 lines · Stephen Hemminger

Do you have any recommendations on how to deal with VMware borkage of the ACPI firmware index?

Hmm, shouldn't the kernel filter such crappy data out already? I mean, if we work around crappy firmware, why should that happen in userspace? So far that was always a kernel job...

Any specific reason you assume that 0xffff is a good cutoff point?

Quoted 21 lines

https://communities.vmware.com/message/2378360

My proposal is to just add special case:

src/udev/udev-builtin-net_id.c +1 -1

index 6e7e127..b8c6f47 100644
@@ -133,7 +133,7 @@ static int dev_pci_onboard(struct udev_device *dev, struct netnames *names) {
         size_t l;
         char *s;
         const char *attr;
-        int idx;
+        unsigned long idx;
 
         /* ACPI _DSM  -- device specific method for naming a PCI or PCI Express device */
         attr = udev_device_get_sysattr_value(names->pcidev, "acpi_index");

@@ -143,8 +143,9 @@ static int dev_pci_onboard(struct udev_device *dev, struct netnames *names) {
         if (!attr)
                 return -ENOENT;
 

src/udev/udev-builtin-net_id.c static int dev_pci_onboard(struct udev_device *dev, struct netnames *names) { · line 151

Quoted 8 lines

src/udev/udev-builtin-net_id.c +2 -1

+        /* vmware returns bogus values */
         idx = strtoul(attr, NULL, 0);
-        if (idx <= 0)
+        if (idx == 0 || idx > 0xffff)
                 return -EINVAL;
 
         /* kernel provided port index for multiple ports on a single PCI function */