Pending rtc-s3c patches
Subsystems (2)
Hi,
There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd like to get an update and either drop or apply those.
Can someone take a few minutes to review them?
The patches are:
http://patchwork.ozlabs.org/patch/71318/
http://patchwork.ozlabs.org/patch/99857/
http://patchwork.ozlabs.org/patch/101732/
I'm not sure about 71318 but I guess I can take 99857 and 101732.
Thanks,
Signature · 14 lines
Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
W dniu 28.10.2015 o 19:14, Alexandre Belloni pisze:
Quoted 5 lines
Hi,
There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd like to get an update and either drop or apply those.
Quoted 8 lines
Can someone take a few minutes to review them?
The patches are:
http://patchwork.ozlabs.org/patch/71318/
http://patchwork.ozlabs.org/patch/99857/
http://patchwork.ozlabs.org/patch/101732/I'm not sure about 71318 but I guess I can take 99857 and 101732.
Hi,
I'll take a look at them in next days. Thanks for digging them out!
Best regards,
Krzysztof
Signature · 9 lines
-- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
W dniu 28.10.2015 o 19:14, Alexandre Belloni pisze:
Quoted 9 lines
Hi,
There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd like to get an update and either drop or apply those.
Can someone take a few minutes to review them?
The patches are:
http://patchwork.ozlabs.org/patch/71318/
This is not needed. The pie_lock (replacing s3c_rtc_pie_lock) protects set_freq() which:
1. is called only during probe;
2. is accessing different registers than s3c_rtc_setaie().
Quoted 1 line
This is good although does not apply cleanly. I rebased, tested and send the patch.
Quoted 1 line
This does not look good. Code is actually used so commit description does not match current state. I think you can ignore it.
Best regards,
Krzysztof
Signature · 9 lines
-- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.