Skip to contentSkip to conversation

NFC: Add Intel Fields Peak NFC solution driver

DISCUSSION Dan Carpenter 1 participant 1 message Nov 3, 2015

lore
Share & tools
lore
#0 lore raw

Hello Robert Dolca,

This is a semi-automatic email about new static checker warnings.

The patch a06347c04c13: "NFC: Add Intel Fields Peak NFC solution driver" from Oct 22, 2015, leads to the following Smatch complaint:

drivers/nfc/fdp/i2c.c:216 fdp_nci_i2c_irq_thread_fn()
warn: variable dereferenced before check 'phy' (see line 213)

drivers/nfc/fdp/i2c.c
212

   213		client = phy->i2c_dev;
                         ^^^^^

Dereference.

214 dev_dbg(&client->dev, "%s\n", __func__);
215

   216		if (!phy || irq != phy->i2c_dev->irq) {
                    ^^^^

Check.

   217			WARN_ON_ONCE(1);
   218			return IRQ_NONE;

regards,
dan carpenter