nvme: lightnvm: clean up a data type
Subsystems (2)
PATCH 1/1 nvme: lightnvm: clean up a data type
"nlb_pr_rq" can't be more than u32 because "len" is a u32. Later we truncate it to u32 anyway when we calculate min_t().
Signed-off-by Dan Carpenter <[email protected]>
drivers/nvme/host/lightnvm.c +2 -2
@@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,struct nvme_dev *dev = ns->dev;struct nvme_nvm_command c = {};u32 len =queue_max_hw_sectors (q) <<9 ; -u64 nlb_pr_rq = len /sizeof (u64); +u32 nlb_pr_rq = len /sizeof (u64);u64 cmd_slba = slba;void *entries;int ret =0 ;
@@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,return -ENOMEM ;while (nlb) { -u32 cmd_nlb =min_t (u32, nlb_pr_rq, nlb); +u32 cmd_nlb =min (nlb_pr_rq, nlb); c.l2p.slba =cpu_to_le64 (cmd_slba); c.l2p.nlb =cpu_to_le32 (cmd_nlb);
Looks right to me. Adding Matias for the last word.
Quoted 27 lines · Dan Carpentar
"
nlb_pr_rq" can't be more than u32 because "len" is a u32. Later we truncate it to u32 anyway when we calculatemin_t().Signed-off-by Dan Carpenter <[email protected]>drivers/nvme/host/lightnvm.c +2
-2@@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,struct nvme_dev *dev = ns->dev;struct nvme_nvm_command c = {};u32 len =queue_max_hw_sectors (q) <<9 ; -u64 nlb_pr_rq = len /sizeof (u64); +u32 nlb_pr_rq = len /sizeof (u64);u64 cmd_slba = slba;void *entries;int ret =0 ;@@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,return -ENOMEM ;while (nlb) { -u32 cmd_nlb =min_t (u32, nlb_pr_rq, nlb); +u32 cmd_nlb =min (nlb_pr_rq, nlb); c.l2p.slba =cpu_to_le64 (cmd_slba); c.l2p.nlb =cpu_to_le32 (cmd_nlb);
Quoted 1 line · Keith
Looks right to me. Adding Matias for the last word.
Thanks Keith and Dan. Looks good to me as well.
Quoted 29 lines · Dan Carpentar
Quoted 27 lines
"
nlb_pr_rq" can't be more than u32 because "len" is a u32. Later we truncate it to u32 anyway when we calculatemin_t().Signed-off-by Dan Carpenter <[email protected]>drivers/nvme/host/lightnvm.c +2
-2@@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,struct nvme_dev *dev = ns->dev;struct nvme_nvm_command c = {};u32 len =queue_max_hw_sectors (q) <<9 ; -u64 nlb_pr_rq = len /sizeof (u64); +u32 nlb_pr_rq = len /sizeof (u64);u64 cmd_slba = slba;void *entries;int ret =0 ;@@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,return -ENOMEM ;while (nlb) { -u32 cmd_nlb =min_t (u32, nlb_pr_rq, nlb); +u32 cmd_nlb =min (nlb_pr_rq, nlb); c.l2p.slba =cpu_to_le64 (cmd_slba); c.l2p.nlb =cpu_to_le32 (cmd_nlb);
Quoted 2 lines · Dan Carpenter
"
nlb_pr_rq" can't be more than u32 because "len" is a u32. Later we truncate it to u32 anyway when we calculatemin_t().
Thanks Dan, applied.
Signature · 1 line
Jens Axboe