qlogic/qed: remove bogus NULL check

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 4, 2015 – Nov 5, 2015

Subsystems (4)

Networking Network drivers Kernel janitors QLogic QL4xxx Ethernet driver

lore

Share & tools

lore

Dan Carpenter

author

2015-11-04 13:27 UTC #0 lore raw

PATCH 1/1 qlogic/qed: remove bogus NULL check

We check if "p_hwfn" is NULL and then dereference it in the error handling code. I read the code and it isn't NULL so let's remove the check.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/qlogic/qed/qed_int.c +0 -5

index 2e399b6..de50e84 100644
@@ -251,11 +251,6 @@ void qed_int_sp_dpc(unsigned long hwfn_cookie)
 	int arr_size;
 	u16 rc = 0;
 
-	if (!p_hwfn) {
-		DP_ERR(p_hwfn->cdev, "DPC called - no hwfn!\n");
-		return;
-	}
-
 	if (!p_hwfn->p_sp_sb) {
 		DP_ERR(p_hwfn->cdev, "DPC called - no p_sp_sb\n");
 		return;

Yuval Mintz

Acked-by on v1 1/1

2015-11-04 13:31 UTC #1 lore raw

Quoted 4 lines

We check if "p_hwfn" is NULL and then dereference it in the error handling code. I read the code and it isn't NULL so let's remove the check.
Signed-off-by Dan Carpenter <[email protected]>

Our current interrupt handling logic is being uber-defensive. Thanks.

Acked-by Yuval Mintz <[email protected]>

David Miller

maintainer Applied

2015-11-05 03:06 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 4 Nov 2015 16:27:16 +0300

Quoted 5 lines

We check if "p_hwfn" is NULL and then dereference it in the error handling code. I read the code and it isn't NULL so let's remove the check.
Signed-off-by Dan Carpenter <[email protected]>

Applied.