Skip to contentSkip to conversation

xprtrdma: clean up some curly braces

PATCH In review Dan Carpenter 2 participants 2 messages Nov 5, 2015

Subsystems (4)
Networking Kernel janitors NFS client NFS server
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 xprtrdma: clean up some curly braces

It doesn't matter either way, but the curly braces were clearly intended here. It causes a Smatch warning.

Signed-off-by Dan Carpenter <[email protected]>
net/sunrpc/xprtrdma/verbs.c +2 -1
index eadd1655..2cc1014 100644
@@ -852,10 +852,11 @@ retry:
 
 		if (extras) {
 			rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
-			if (rc)
+			if (rc) {
 				pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
 					__func__, rc);
 				rc = 0;
+			}
 		}
 	}
Reviewed-by on v1 1/2
#1 lore raw
Quoted 7 lines · Dan Carpenter

It doesn't matter either way, but the curly braces were clearly intended here. It causes a Smatch warning.

Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Chuck Lever <[email protected]>
Quoted 7 lines
net/sunrpc/xprtrdma/verbs.c +0 -0
index eadd1655..2cc1014 100644
@@ -852,10 +852,11 @@ retry:
 
 		if (extras) {

net/sunrpc/xprtrdma/verbs.c retry: · line 862

Quoted 10 lines
net/sunrpc/xprtrdma/verbs.c +2 -1
 			rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
-			if (rc)
+			if (rc) {
 				pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
 					__func__, rc);
 				rc = 0;
+			}
 		}
 	}

—
Chuck Lever

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html