Skip to contentSkip to conversation

staging: rtl8188eu: use memset instead of for loop

PATCH In review Ivan Safonov 1 participant 1 message Nov 8, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 6/12 staging: rtl8188eu: use memset instead of for loop

memset clearer than the for loop.

---
 drivers/staging/rtl8188eu/hal/fw.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8188eu/hal/fw.c +4 -4
index 7f1df4d..298e3e8 100644
@@ -77,12 +77,12 @@ static void _rtl88e_fw_block_write(struct adapter *adapt,
 
 static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
 {
-	u32 i;
+	u32 remain = round_up(pfwlen, 4) - pfwlen;
 
-	for (i = pfwlen; i < roundup(pfwlen, 4); i++)
-		pfwbuf[i] = 0;
+	if (remain)
+		memset(pfwbuf, 0, remain);
 
-	return i;
+	return pfwlen + remain;
 }
 
 static void _rtl88e_fw_page_write(struct adapter *adapt,
Signature · 1 line
2.4.10