Skip to contentSkip to conversation

usb: chipidea: removing of_find_property

PATCH Julia Lawall 2 participants 2 messages Nov 17, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201511172007.DmGhbpj1%[email protected]

#1 lore raw

Please check. The code, with the blank line on line 692, looks strange.

julia

Quoted 46 lines · kbuild test robot

CC: [email protected]
In-Reply-To: <[email protected]>
TO: Saurabh Sengar <[email protected]>
CC: [email protected], [email protected], [email protected], [email protected], [email protected], Saurabh Sengar <[email protected]>
CC: Saurabh Sengar <[email protected]>

Hi Saurabh,

[auto build test WARNING on peter.chen-usb/ci-for-usb-next] [also build test WARNING on v4.4-rc1 next-20151117]

url:    https://github.com/0day-ci/linux/commits/Saurabh-Sengar/usb-chipidea-removing-of_find_property/20151117-194333
base:   https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next

:::::: branch date: 68 minutes ago
:::::: commit date: 68 minutes ago

Quoted 1 line
Quoted 1 line

drivers/usb/chipidea/core.c:693:1-27: code aligned with following code on line 695

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 4375ac1189e900bbde912d31ec3bb66572c0784a vim +693 drivers/usb/chipidea/core.c

63863b98 Heikki Krogerus   2015-09-21  687  	if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)
4f6743d5 Michael Grzeschik 2014-02-19  688  		platdata->flags |= CI_HDRC_FORCE_FULLSPEED;
4f6743d5 Michael Grzeschik 2014-02-19  689
4375ac11 Saurabh Sengar    2015-11-17  690  	if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
4375ac11 Saurabh Sengar    2015-11-17  691  				     &platdata->phy_clkgate_delay_us))
1fbf4628 Fabio Estevam     2015-09-08  692
df96ed8d Peter Chen        2014-09-22 @693  	platdata->itc_setting = 1;
4375ac11 Saurabh Sengar    2015-11-17  694
df96ed8d Peter Chen        2014-09-22 @695  	ret = of_property_read_u32(dev->of_node, "itc-setting",
df96ed8d Peter Chen        2014-09-22  696  					&platdata->itc_setting);
4375ac11 Saurabh Sengar    2015-11-17  697  	if (ret && ret != -EINVAL) {
4375ac11 Saurabh Sengar    2015-11-17  698  		dev_err(dev, "failed to get itc-setting\n");

:::::: The code at line 693 was first introduced by commit
:::::: df96ed8dced21426c54c7f69cf7513e75280957a usb: chipidea: introduce ITC tuning interface

:::::: TO: Peter Chen <[email protected]>
:::::: CC: Peter Chen <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#2 lore raw

Hi Julia,

You have used v2 of patch, I have sent v3 of patch too. 1:30 hour before Please use version 3 as that is the latest.
version 3 : https://lkml.org/lkml/2015/11/17/243

Sorry for trouble.

Regards,
Saurabh

Quoted 52 lines · Julia Lawall

Please check. The code, with the blank line on line 692, looks strange.

julia

Quoted 46 lines · kbuild test robot

CC: [email protected]
In-Reply-To: <[email protected]>
TO: Saurabh Sengar <[email protected]>
CC: [email protected], [email protected], [email protected], [email protected], [email protected], Saurabh Sengar <[email protected]>
CC: Saurabh Sengar <[email protected]>

Hi Saurabh,

[auto build test WARNING on peter.chen-usb/ci-for-usb-next] [also build test WARNING on v4.4-rc1 next-20151117]

url:    https://github.com/0day-ci/linux/commits/Saurabh-Sengar/usb-chipidea-removing-of_find_property/20151117-194333
base:   https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next

:::::: branch date: 68 minutes ago
:::::: commit date: 68 minutes ago

Quoted 1 line
Quoted 1 line

drivers/usb/chipidea/core.c:693:1-27: code aligned with following code on line 695

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 4375ac1189e900bbde912d31ec3bb66572c0784a vim +693 drivers/usb/chipidea/core.c

63863b98 Heikki Krogerus   2015-09-21  687    if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)
4f6743d5 Michael Grzeschik 2014-02-19  688            platdata->flags |= CI_HDRC_FORCE_FULLSPEED;
4f6743d5 Michael Grzeschik 2014-02-19  689
4375ac11 Saurabh Sengar    2015-11-17  690    if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
4375ac11 Saurabh Sengar    2015-11-17  691                                 &platdata->phy_clkgate_delay_us))
1fbf4628 Fabio Estevam     2015-09-08  692
df96ed8d Peter Chen        2014-09-22 @693    platdata->itc_setting = 1;
4375ac11 Saurabh Sengar    2015-11-17  694
df96ed8d Peter Chen        2014-09-22 @695    ret = of_property_read_u32(dev->of_node, "itc-setting",
df96ed8d Peter Chen        2014-09-22  696                                    &platdata->itc_setting);
4375ac11 Saurabh Sengar    2015-11-17  697    if (ret && ret != -EINVAL) {
4375ac11 Saurabh Sengar    2015-11-17  698            dev_err(dev, "failed to get itc-setting\n");

:::::: The code at line 693 was first introduced by commit
:::::: df96ed8dced21426c54c7f69cf7513e75280957a usb: chipidea: introduce ITC tuning interface

:::::: TO: Peter Chen <[email protected]>
:::::: CC: Peter Chen <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation