Skip to contentSkip to conversation

add blacklist for thinkpad T40p

radeon agp Pavel Machek 3 participants 5 messages Nov 28, 2015 – Dec 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Thinkpad T40p needs agpmode 1.

drivers/gpu/drm/radeon/radeon_agp.c +3 -0
index fe994aa..c77d349 100644
@@ -54,6 +54,9 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
 	/* Intel 82855PM host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (lp #195051) */
 	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4e50,
 		PCI_VENDOR_ID_IBM, 0x0550, 1},
+	/* Intel 82855PM host bridge / RV250/M9 GL [Mobility FireGL 9000/Radeon 9000] needs AGPMode 1 (Thinkpad T40p) */
+	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
+		PCI_VENDOR_ID_IBM, 0x054d, 1},
 	/* Intel 82855PM host bridge / Mobility M7 needs AGPMode 1 */
 	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c57,
 		PCI_VENDOR_ID_IBM, 0x0530, 1},
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 4 lines · Pavel Machek

Thinkpad T40p needs agpmode 1.

Seems odd that this wouldn't have been found earlier given how popular thinkpads are. Applied. Thanks,

Alex

Quoted 17 lines
drivers/gpu/drm/radeon/radeon_agp.c +3 -1
index fe994aa..c77d349 100644
@@ -54,6 +54,9 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
        /* Intel 82855PM host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (lp #195051) */
        { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4e50,
                PCI_VENDOR_ID_IBM, 0x0550, 1},
+       /* Intel 82855PM host bridge / RV250/M9 GL [Mobility FireGL 9000/Radeon 9000] needs AGPMode 1 (Thinkpad T40p) */
+       { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
+               PCI_VENDOR_ID_IBM, 0x054d, 1},
        /* Intel 82855PM host bridge / Mobility M7 needs AGPMode 1 */
        { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c57,
                PCI_VENDOR_ID_IBM, 0x0530, 1},
 
--
Quoted 6 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 9 lines · Alex Deucher
Quoted 4 lines · Pavel Machek

Thinkpad T40p needs agpmode 1.

Seems odd that this wouldn't have been found earlier given how popular thinkpads are. Applied. Thanks,

Wondering if it wouldn't be better to apply these restrictions within the AGP driver. I have a vague recollection that (at least?) some of these are chipset limitations/bugs ?

Thanks
Emil
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 5 lines · Emil Velikov
Quoted 4 lines · Alex Deucher
Quoted 3 lines · Pavel Machek

Thinkpad T40p needs agpmode 1.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Seems odd that this wouldn't have been found earlier given how popular thinkpads are. Applied. Thanks,

Wondering if it wouldn't be better to apply these restrictions within the AGP driver. I have a vague recollection that (at least?) some of these are chipset limitations/bugs ?

I think it's probably better in the GPU drivers. AGP was always problematic. There are a number of quirks that were necessary for some users but not others on the same hardware. Additionally, the combination of vendors or even driver versions/behaviors were problematic. E.g., with UMS, the drivers didn't use much gart since there was just a single static allocation. Once we switched to KMS, lots of new bugs surfaced. Chipset A plus GPU vendor B worked fined, but chipset A with GPU vendor C was problematic.

Alex
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 15 lines · Alex Deucher
Quoted 5 lines · Emil Velikov
Quoted 4 lines · Alex Deucher
Quoted 3 lines · Pavel Machek

Thinkpad T40p needs agpmode 1.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Seems odd that this wouldn't have been found earlier given how popular thinkpads are. Applied. Thanks,

Wondering if it wouldn't be better to apply these restrictions within the AGP driver. I have a vague recollection that (at least?) some of these are chipset limitations/bugs ?

Quoted 9 lines

I think it's probably better in the GPU drivers. AGP was always problematic. There are a number of quirks that were necessary for some users but not others on the same hardware. Additionally, the combination of vendors or even driver versions/behaviors were problematic. E.g., with UMS, the drivers didn't use much gart since there was just a single static allocation. Once we switched to KMS, lots of new bugs surfaced. Chipset A plus GPU vendor B worked fined, but chipset A with GPU vendor C was problematic.

Looking at how many cases with identical vendor/device (yet differing sub vendor/device) are there, plus some of these also available in nouveau I'm wondering if it's truly a case of things "working" for some as opposed to different test(ing procedure) being applied. That assumption comes along nicely with how 'delayed' this report is.

That said I'm not pushing on anything, just pointing out the pattern I see.

Emil
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel