Skip to contentSkip to conversation

u-boot-usb/master

GIT PULL NAK Marek Vasut 3 participants 9 messages Nov 30, 2015

lore
Share & tools
lore
#0 lore raw

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:

Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03
-0500)

are available in the git repository at:

git://git.denx.de/u-boot-usb.git

for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:

drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
(2015-11-30 13:33:22 +0100)

----------------------------------------------------------------
Alexey Brodkin (1):
usb: add support for generic EHCI devices

Felipe Balbi (2):
usb: host: xhci-omap: fix build break
usb: dwc3: fix build warnings

Rajesh Bhagat (1):
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw
workaround

Siva Durga Prasad Paladugu (2):
usb: zynqmp: Add XHCI driver support
usb: zynqmp: Enable USB XHCI support

 drivers/usb/dwc3/core.c            |   2 +-
 drivers/usb/dwc3/dwc3-omap.c       |   2 +-
 drivers/usb/host/Kconfig           |   7 +++++
 drivers/usb/host/Makefile          |   2 ++
 drivers/usb/host/ehci-generic.c    |  51 +++++++++++++++++++++++++++++++++++++
 drivers/usb/host/xhci-omap.c       |   2 +-
 drivers/usb/host/xhci-zynqmp.c     | 143 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/configs/xilinx_zynqmp.h    |   8 ++++++
 include/configs/xilinx_zynqmp_ep.h |   2 ++
 include/fsl_usb.h                  |   1 +
 10 files changed, 217 insertions(+), 3 deletions(-)
 create mode 100644 drivers/usb/host/ehci-generic.c
 create mode 100644 drivers/usb/host/xhci-zynqmp.c
#1 lore raw
Quoted 5 lines · Marek Vasut

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:

Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03
-0500)

Quoted 9 lines

are available in the git repository at:

git://git.denx.de/u-boot-usb.git

for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:

drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
(2015-11-30 13:33:22 +0100)

NAK:
+(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nano,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXino-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3,Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_box,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orangepi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A13-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0):
multiple definition of `_u_boot_list_2_driver_2_usb_ehci'
...
+(ph1_sld8,ph1_sld3,ph1_ld4)
build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
...
w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning:
'return' with a value, in function returning void

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151130/3db040cf/attachment.sig>
#2 lore raw
Quoted 32 lines · Tom Rini
Quoted 6 lines · Marek Vasut

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:
Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03

-0500)

Quoted 8 lines

are available in the git repository at:
git://git.denx.de/u-boot-usb.git

for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround

(2015-11-30 13:33:22 +0100)

NAK:
+(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0):

Quoted 8 lines

multiple definition of `_u_boot_list_2_driver_2_usb_ehci'
...
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
...
w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning:
'return' with a value, in function returning void

Can you try dropping the ehci-generic patch ?

Best regards,
Marek Vasut

#3 lore raw
Quoted 35 lines · Marek Vasut
Quoted 34 lines · Tom Rini
Quoted 6 lines · Marek Vasut

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:
Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03

-0500)

Quoted 8 lines

are available in the git repository at:
git://git.denx.de/u-boot-usb.git

for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround

(2015-11-30 13:33:22 +0100)

NAK:
+(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0):
multiple definition of `_u_boot_list_2_driver_2_usb_ehci'
...

Quoted 8 lines
Quoted 6 lines

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
...
w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning:
'return' with a value, in function returning void

Can you try dropping the ehci-generic patch ?

I'm re-testing a number of other PRs right now. Please try it locally, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151130/fe69d7d0/attachment.sig>
#4 lore raw
In reply to Tom Rini
Quoted 25 lines · Tom Rini
Quoted 6 lines · Marek Vasut

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:
Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03

-0500)

Quoted 8 lines

are available in the git repository at:
git://git.denx.de/u-boot-usb.git

for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround

(2015-11-30 13:33:22 +0100)

NAK:
+(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M

Quoted 8 lines

9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0):
multiple definition of `_u_boot_list_2_driver_2_usb_ehci'

Not my doing, but I can fix this.

Quoted 3 lines

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'

I'm dropping the ehci-generic for now.

Quoted 3 lines

...
w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning:
'return' with a value, in function returning void

OK, I fixed this one.

Best regards,
Marek Vasut

#5 lore raw

Hi Tom,

Quoted 6 lines · Marek Vasut
Quoted 5 lines · Tom Rini
Quoted 1 line · Marek Vasut

T

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'

I'm wondering how may I reproduce this failure?

For me following (assuming ARC toolchain is in PATHs, see
http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly:
---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------

-Alexey

#6 lore raw
Quoted 11 lines · Alexey Brodkin

Hi Tom,

Quoted 7 lines · Marek Vasut
Quoted 6 lines · Tom Rini
Quoted 1 line · Marek Vasut

T

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'

Quoted 7 lines

I'm wondering how may I reproduce this failure?

For me following (assuming ARC toolchain is in PATHs, see
http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly:
---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------

Try compiling either of the machines -- ph1_sld8 or ph1_sld3 or ph1_ld4

Best regards,
Marek Vasut

#7 lore raw
In reply to Alexey Brodkin
Quoted 10 lines · Alexey Brodkin

Hi Tom,

Quoted 6 lines · Marek Vasut
Quoted 5 lines · Tom Rini
Quoted 1 line · Marek Vasut

T

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'

Quoted 7 lines

I'm wondering how may I reproduce this failure?

For me following (assuming ARC toolchain is in PATHs, see
http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly:
---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------

Build for ph1_sld8 or one of the other listed ARM boards :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151130/67aaed9e/attachment.sig>
#8 lore raw

Hi Tom, Marek,

Quoted 13 lines · Tom Rini
Quoted 12 lines · Alexey Brodkin

Hi Tom,

Quoted 6 lines · Marek Vasut
Quoted 5 lines · Tom Rini
Quoted 1 line · Marek Vasut

T

+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'

I'm wondering how may I reproduce this failure?

Quoted 7 lines
Quoted 5 lines

For me following (assuming ARC toolchain is in PATHs, see
http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly:
---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------

Build for ph1_sld8 or one of the other listed ARM boards :)

Obvious SNAFU - new driver enabled by default.
All other EHCI drivers are also enabled by default but limited by either architecture or platforms.

v3 is on its way - I'm really sorry for that :(

-Alexey