Skip to contentSkip to conversation

acpi: Better describe ACPI_DEBUGGER

PATCH Applied Peter Zijlstra 3 participants 4 messages Nov 30, 2015 – Dec 1, 2015 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acpi: Better describe ACPI_DEBUGGER

Hi,

For a brief moment I was tricked into thinking that:

In-kernel debugger (EXPERIMENTAL) (ACPI_DEBUGGER) [N/y/?] (NEW)

might be something useful. Better describe the feature to reduce such confusion.

---
 drivers/acpi/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/Kconfig +2 -2
index 25dbb76c02cc..5eef4cb4f70e 100644
@@ -58,10 +58,10 @@ config ACPI_CCA_REQUIRED
 	bool
 
 config ACPI_DEBUGGER
-	bool "In-kernel debugger (EXPERIMENTAL)"
+	bool "AML debugger interface (EXPERIMENTAL)"
 	select ACPI_DEBUG
 	help
-	  Enable in-kernel debugging facilities: statistics, internal
+	  Enable in-kernel debugging of AML facilities: statistics, internal
 	  object dump, single step control method execution.
 	  This is still under development, currently enabling this only
 	  results in the compilation of the ACPICA debugger files.
#1 lore raw
Quoted 10 lines · Peter Zijlstra

Hi,

For a brief moment I was tricked into thinking that:

In-kernel debugger (EXPERIMENTAL) (ACPI_DEBUGGER) [N/y/?] (NEW)

might be something useful. Better describe the feature to reduce such confusion.

Applied, thanks!

I should have caught that, sorry for the sloppiness.

Thanks,
Rafael

#2 lore raw
Quoted 7 lines · Rafael J. Wysocki
Quoted 6 lines · Peter Zijlstra

Hi,

For a brief moment I was tricked into thinking that:

In-kernel debugger (EXPERIMENTAL) (ACPI_DEBUGGER) [N/y/?] (NEW)

Quoted 8 lines
Quoted 4 lines

might be something useful. Better describe the feature to reduce such confusion.

Applied, thanks!

I should have caught that, sorry for the sloppiness.

n/p, for a brief moment I thought about things like a GDB stub running in SMM -- which would be entirely awesome if it had dedicated IO through a BMC or simple serial.

Then I thought about all the kvm-gdb-stub fail I've encountered over the years and figured this would never work, seeing how BIOSes are never updated/fixed.

#3 lore raw
Quoted 2 lines · Peter Zijlstra
Quoted 1 line · Rafael J. Wysocki

On Monday, November 30, 2015 10:32:15 PM Peter Zijlstra wrote:

[...]

Quoted 7 lines

n/p, for a brief moment I thought about things like a GDB stub running in SMM -- which would be entirely awesome if it had dedicated IO through a BMC or simple serial.

Then I thought about all the kvm-gdb-stub fail I've encountered over the years and figured this would never work, seeing how BIOSes are never updated/fixed.

FYI, at Usenix WOOT'15, Intel talked about using a GDB stub to test SMM, along with S2E, KLEE, OpenOCD, and Minnow. I *think* Intel is going to be open-sourcing the resulting test project next quarter. Unclear if this will impact ACPI.

https://www.usenix.org/conference/woot15/workshop-program/presentation/bazhaniuk

"Symbolic Execution for BIOS Security: We are building a tool that uses symbolic execution to search for BIOS security vulnerabilities including dangerous memory references (call outs) by SMM interrupt handlers in UEFI-compliant implementations of BIOS. Our tool currently applies only to interrupt handlers for SMM variables. Given a snapshot of SMRAM, the base address of SMRAM, and the address of the variable interrupt handler in SMRAM, the tool uses S2E to run the KLEE symbolic execution engine to search for concrete examples of a call to the interrupt handler that causes the handler to read memory outside of SMRAM. This is a work in progress. We discuss our approach, our current status, our plans for the tool, and the obstacles we face."

Thanks,
Lee
RSS: http://firmwaresecurity.com/feed