iio: exynos-adc: fix irqf_oneshot.cocci warnings
Subsystems (2)
PATCH 1/1 iio: exynos-adc: fix irqf_oneshot.cocci warnings
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
---
The patch looks fine to me: bad things can happen when interrupts are acked before the handler ran.
exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +1 -1
@@ -739,7 +739,7 @@ static int exynos_adc_ts_init(struct exydisable_irq (info->tsirq); ret =request_threaded_irq (info->tsirq,NULL , exynos_ts_isr, -0 ,"touchscreen" , info); +IRQF_ONESHOT ,"touchscreen" , info);if (ret)input_unregister_device (info->input);
Olof Johansson
AppliedQuoted 6 lines · Valentin Rothberg
Since commit
1c6c69525b40("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested withIRQF_ONESHOT, otherwise the request will fail.So pass the
IRQF_ONESHOTflag in this case.
Quoted 8 lines
Generated by:
scripts/coccinelle/misc/irqf_oneshot.cocciSigned-off-by Fengguang Wu <[email protected]>Signed-off-by Valentin Rothberg <[email protected]>---
The patch looks fine to me: bad things can happen when interrupts are acked before the handler ran.
Hi,
Applied. Thanks.
-Olof