Skip to contentSkip to conversation

iio: exynos-adc: fix irqf_oneshot.cocci warnings

PATCH Applied Valentin Rothberg 2 participants 2 messages Dec 2, 2015 – Dec 22, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: exynos-adc: fix irqf_oneshot.cocci warnings

Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

---

The patch looks fine to me: bad things can happen when interrupts are acked before the handler ran.

 exynos_adc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +1 -1
@@ -739,7 +739,7 @@ static int exynos_adc_ts_init(struct exy
 
 	disable_irq(info->tsirq);
 	ret = request_threaded_irq(info->tsirq, NULL, exynos_ts_isr,
-				   0, "touchscreen", info);
+				   IRQF_ONESHOT, "touchscreen", info);
 	if (ret)
 		input_unregister_device(info->input);
 
#1 lore raw
Quoted 6 lines · Valentin Rothberg

Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

Quoted 8 lines

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

---

The patch looks fine to me: bad things can happen when interrupts are acked before the handler ran.

Hi,

Applied. Thanks.

-Olof