Skip to contentSkip to conversation

radeon -Wmaybe-uninitialized crap

DISCUSSION Borislav Petkov 2 participants 4 messages Dec 7, 2015 – Dec 11, 2015

lore
Share & tools
lore
#0 lore raw

Hi guys,

this just started appearing when building -rc4. Got fixes yet? :-)

In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,

                 from drivers/gpu/drm/radeon/radeon.h:80,
                 from drivers/gpu/drm/radeon/r100.c:33:
drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  u64 tmp = ((u64)A.full << 13);
             ^
drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was declared here
  fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff;
                                                               ^
drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     temp_ff.full = read_return_rate.full - disp_drain_rate.full;
                                          ^
Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Borislav Petkov [mailto:[email protected]]
Sent: Monday, December 07, 2015 3:56 AM
To: Deucher, Alexander; Koenig, Christian
Cc: lkml
Subject: radeon -Wmaybe-uninitialized crap

Quoted 3 lines

Hi guys,

this just started appearing when building -rc4. Got fixes yet? :-)

Odd. Nothing related to these variables has changed in years.

Alex

Quoted 18 lines

In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,

                 from drivers/gpu/drm/radeon/radeon.h:80,
                 from drivers/gpu/drm/radeon/r100.c:33:
drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  u64 tmp = ((u64)A.full << 13);
             ^
drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was
declared here
  fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff,
crit_point_ff;
                                                               ^
drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may
be used uninitialized in this function [-Wmaybe-uninitialized]
     temp_ff.full = read_return_rate.full - disp_drain_rate.full;
                                          ^
Quoted 5 lines

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�

#2 lore raw
Quoted 1 line · Alexander

Odd. Nothing related to these variables has changed in years.

Odd indeed. Building that same config on two other boxes doesn't trip those up so it must be something gcc-related on that particular box.

Hmmm.

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
#3 lore raw
Quoted 5 lines · Borislav Petkov
Quoted 1 line · Alexander

Odd. Nothing related to these variables has changed in years.

Odd indeed. Building that same config on two other boxes doesn't trip those up so it must be something gcc-related on that particular box.

Just appeared on another box (ph) too:

In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,

                 from drivers/gpu/drm/radeon/radeon.h:80,
                 from drivers/gpu/drm/radeon/r100.c:33:
drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  u64 tmp = ((u64)A.full << 13);
             ^
drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was declared here
  fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff;
                                                               ^
drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     temp_ff.full = read_return_rate.full - disp_drain_rate.full;
                                          ^
Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.