mlxsw: core: remove an unneeded condition

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 9, 2015 – Dec 12, 2015

Subsystems (4)

Networking Network drivers Kernel janitors Mellanox Ethernet switch drivers

lore

Share & tools

lore

Dan Carpenter

author

2015-12-09 10:41 UTC #0 lore raw

PATCH 1/1 mlxsw: core: remove an unneeded condition

We already know "err" is zero so there is no need to check.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c +1 -1

index 4dad146..913106d 100644
@@ -169,7 +169,7 @@ static ssize_t mlxsw_hwmon_pwm_store(struct device *dev,
 		dev_err(mlxsw_hwmon->bus_info->dev, "Failed to write PWM\n");
 		return err;
 	}
-	return err ? err : len;
+	return len;
 }
 
 enum mlxsw_hwmon_attr_type {

Jiri Pirko

Acked-by on v1 1/1

2015-12-09 10:47 UTC #1 lore raw

Quoted 3 lines · Wed, Dec 09, 2015 at 11:41:29AM CET, [email protected] wrote:

We already know "err" is zero so there is no need to check.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Jiri Pirko <[email protected]>

Thanks.

David Miller

maintainer Applied

2015-12-12 01:15 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 9 Dec 2015 13:41:29 +0300

Quoted 3 lines

We already know "err" is zero so there is no need to check.
Signed-off-by Dan Carpenter <[email protected]>

Applied.