ath10k: replace vdev_id and tid in skb cb
Hello Michal Kazior,
This is a semi-automatic email about new static checker warnings.
The patch 609db229b42f: "ath10k: replace vdev_id and tid in skb cb" from Nov 18, 2015, leads to the following Smatch complaint:
drivers/net/wireless/ath/ath10k/htt_tx.c:450 ath10k_htt_tx_get_vdev_id()
warn: variable dereferenced before check 'cb->vif' (see line 446)
drivers/net/wireless/ath/ath10k/htt_tx.c
445 struct ath10k_skb_cb *cb = ATH10K_SKB_CB(skb);
446 struct ath10k_vif *arvif = (void *)cb->vif->drv_priv;
^^^^^^^^^Dereference.
447
448 if (info->flags & IEEE80211_TX_CTL_TX_OFFCHAN)
449 return ar->scan.vdev_id;
450 else if (cb->vif)
^^^^^^^
Checked too late.
451 return arvif->vdev_id;
452 else if (ar->monitor_started)
See also:drivers/net/wireless/ath/ath10k/wmi.c:1830 ath10k_wmi_op_gen_mgmt_tx() warn: variable dereferenced before check 'cb->vif' (see line 1818)
regards,
dan carpenter
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 14 lines · Dan Carpenter
Hello Michal Kazior,
This is a semi-automatic email about new static checker warnings.
The patch
609db229b42f: "ath10k: replacevdev_idand tid in skb cb" from Nov 18, 2015, leads to the following Smatch complaint:
drivers/net/wireless/ath/ath10k/htt_tx.c:450ath10k_htt_tx_get_vdev_id()warn: variable dereferenced before check 'cb->vif' (see line 446)
drivers/net/wireless/ath/ath10k/htt_tx.c445 struct ath10k_skb_cb *cb = ATH10K_SKB_CB(skb); 446 struct ath10k_vif *arvif = (void *)cb->vif->drv_priv; ^^^^^^^^^
Quoted 8 lines
Dereference.
447 448 if (info->flags & IEEE80211_TX_CTL_TX_OFFCHAN) 449 return ar->scan.vdev_id; 450 else if (cb->vif) ^^^^^^^Checked too late.
This is a false positive.
The drv_priv is a 0-len/dynamic array at the end of ieee80211_vif struct. The cb->vif->drv_priv expression should be expanded to a mere (cb->vif)+offsetof(drv_priv) which isn't a dereference per se.
Michał
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k