mic_virtio: fix a timeout loop

PATCH New Dan Carpenter 1 participant 1 message Dec 15, 2015

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2015-12-15 10:11 UTC #0 lore raw

PATCH 1/1 mic_virtio: fix a timeout loop

After the loop we test "if (!retry)" to see if we timedout. The problem is "retry--" is a post-op so retry will be -1 at the end of the loop. I have fixed this by changing it to a pre-op instead.

Signed-off-by Dan Carpenter <[email protected]>

drivers/misc/mic/card/mic_virtio.c +1 -1

index e486a0c..b3ad9c4 100644
@@ -337,7 +337,7 @@ static int mic_find_vqs(struct virtio_device *vdev, unsigned nvqs,
 	 * rings have been re-assigned.
 	 */
 	mic_send_intr(mvdev->mdev, mvdev->c2h_vdev_db);
-	for (retry = 100; retry--;) {
+	for (retry = 100; --retry;) {
 		if (!ioread8(&dc->used_address_updated))
 			break;
 		msleep(100);