USB: ipaq.c: fix a timeout loop

PATCH New Dan Carpenter 1 participant 1 message Dec 16, 2015

Subsystems (3)

USB Kernel janitors USB serial

lore

Share & tools

lore

Dan Carpenter

author

2015-12-16 11:06 UTC #0 lore raw

PATCH 1/1 USB: ipaq.c: fix a timeout loop

The code expects the loop to end with "retries" set to zero but, because it is a post-op, it will end set to -1. I have fixed this by moving the decrement inside the loop.

Fixes 014aa2a3c32e ('USB: ipaq: minor ipaq_open() cleanup.')

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/serial/ipaq.c +2 -1

index f51a5d5..ec1b8f2 100644
@@ -531,7 +531,8 @@ static int ipaq_open(struct tty_struct *tty,
 	 * through. Since this has a reasonably high failure rate, we retry
 	 * several times.
 	 */
-	while (retries--) {
+	while (retries) {
+		retries--;
 		result = usb_control_msg(serial->dev,
 				usb_sndctrlpipe(serial->dev, 0), 0x22, 0x21,
 				0x1, 0, NULL, 0, 100);