Skip to contentSkip to conversation

usb: dwc2: host: use list_for_each_entry_safe

PATCH Julia Lawall 1 participant 1 message Dec 18, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201512190215.mdgzsk4H%[email protected]

#1 lore raw

The call on line 1120 looks suspicious, because qtd could be non-null but also not a valid element, if the loop has exited normally.

julia

Quoted 67 lines · kbuild test robot

CC: [email protected]
In-Reply-To: <c123b5df7c51a27f33f0d423bf4752a221559fd1.1450455486.git.geliangtang@163.com>
TO: Geliang Tang <[email protected]>
CC: John Youn <[email protected]>, Greg Kroah-Hartman <[email protected]>
CC: Geliang Tang <[email protected]>, [email protected], [email protected]

Hi Geliang,

[auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.4-rc5 next-20151218]

url:    https://github.com/0day-ci/linux/commits/Geliang-Tang/usb-host-fotg210-use-list_for_each_entry_safe/20151219-003955
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing

:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Quoted 1 line
Quoted 1 line

drivers/usb/dwc2/hcd_ddma.c:1119:11-14: ERROR: invalid reference to the index variable of the iterator on line 1096

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 61366173f3eb9bee0d5cd22e6a7c5407b14087cb vim +1119 drivers/usb/dwc2/hcd_ddma.c

dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1090  	if (chan->halt_status == DWC2_HC_XFER_URB_DEQUEUE) {
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1091  		list_for_each_entry(qtd, &qh->qtd_list, qtd_list_entry)
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1092  			qtd->in_process = 0;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1093  		return;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1094  	}
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1095  
61366173 drivers/usb/dwc2/hcd_ddma.c     Geliang Tang   2015-12-19 @1096  	list_for_each_entry_safe(qtd, tmp, &qh->qtd_list, qtd_list_entry) {
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1097  		int i;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1098  
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1099  		xfer_done = 0;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1100  
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1101  		for (i = 0; i < qtd->n_desc; i++) {
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1102  			if (dwc2_process_non_isoc_desc(hsotg, chan, chnum, qtd,
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1103  						       desc_num, halt_status,
fbd1cd20 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-11-22  1104  						       &xfer_done)) {
fbd1cd20 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-11-22  1105  				qtd = NULL;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1106  				break;
fbd1cd20 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-11-22  1107  			}
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1108  			desc_num++;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1109  		}
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1110  	}
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1111  
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1112  	if (qh->ep_type != USB_ENDPOINT_XFER_CONTROL) {
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1113  		/*
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1114  		 * Resetting the data toggle for bulk and interrupt endpoints
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1115  		 * in case of stall. See handle_hc_stall_intr().
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1116  		 */
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1117  		if (halt_status == DWC2_HC_XFER_STALL)
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1118  			qh->data_toggle = DWC2_HC_PID_DATA0;
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11 @1119  		else if (qtd)
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1120  			dwc2_hcd_save_data_toggle(hsotg, chan, chnum, qtd);
dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11  1121  	}

dc4c76e7 drivers/staging/dwc2/hcd_ddma.c Paul Zimmerman 2013-03-11 1122

:::::: The code at line 1119 was first introduced by commit
:::::: dc4c76e7b22cdcc1ba71ff87edee55f464e01658 staging: HCD descriptor DMA support for the DWC2 driver

:::::: TO: Paul Zimmerman <[email protected]> :::::: CC: Greg Kroah-Hartman <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation