ACPI / debugger: remove some unneeded conditions

PATCH In review Dan Carpenter 1 participant 1 message Dec 24, 2015

Subsystems (2)

Kernel janitors ACPI

lore

Share & tools

lore

Dan Carpenter

author

2015-12-24 07:23 UTC #0 lore raw

PATCH 1/2 ACPI / debugger: remove some unneeded conditions

"count" is unsigned so checking for less than zero here causes a static checker warning. And really it's better to let the access_ok() check fail if the user passes in a NULL "buf" pointer because -EFAULT is the correct error code.

Signed-off-by Dan Carpenter <[email protected]>

drivers/acpi/acpi_dbg.c +0 -4

index 381beb2..f2c92ab 100644
@@ -610,8 +610,6 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf,
 	int ret = 0;
 	int size = 0;
 
-	if (!buf || count < 0)
-		return -EINVAL;
 	if (!count)
 		return 0;
 	if (!access_ok(VERIFY_WRITE, buf, count))

@@ -681,8 +679,6 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf,
 	int ret = 0;
 	int size = 0;
 
-	if (!buf || count < 0)
-		return -EINVAL;
 	if (!count)
 		return 0;
 	if (!access_ok(VERIFY_READ, buf, count))