Skip to contentSkip to conversation

omapfb: copy omapdss & displays for omapfb

DISCUSSION Dan Carpenter 1 participant 2 messages Jan 4, 2016 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

Hello Tomi Valkeinen,

This is a semi-automatic email about new static checker warnings.

The patch f76ee892a99e: "omapfb: copy omapdss & displays for omapfb" from Dec 9, 2015, leads to the following Smatch complaint:

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:113 sharp_ls_enable()

	 error: we previously assumed 'ddata->vcc' could be null (see line 105)

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c
104

   105		if (ddata->vcc) {
                    ^^^^^^^^^^

Check for NULL.

106 r = regulator_enable(ddata->vcc);
107 if (r != 0)
108 return r;
109 }
110
111 r = in->ops.dpi->enable(in);
112 if (r) {

   113			regulator_disable(ddata->vcc);
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Unchecked deref inside function.

114 return r;
115 }

regards,
dan carpenter

#1 lore raw

Hello Tomi Valkeinen,

The patch f76ee892a99e: "omapfb: copy omapdss & displays for omapfb" from Dec 9, 2015, leads to the following static checker warning:

	drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:213 sharp_ls_get_gpio()
	warn: 'gd' isn't an ERR_PTR

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c
200 static int sharp_ls_get_gpio(struct device *dev, int gpio, unsigned long flags,
201 char *desc, struct gpio_desc **gpiod)
202 {
203 struct gpio_desc *gd;
204 int r;
205
206 *gpiod = NULL;
207
208 r = devm_gpio_request_one(dev, gpio, flags, desc);
209 if (r)
210 return r = -ENOENT ? 0 : r;
211
212 gd = gpio_to_desc(gpio);
213 if (IS_ERR(gd))
214 return PTR_ERR(gd) = -ENOENT ? 0 : PTR_ERR(gd);

This doesn't work. It's either compiled out (ENOENT) or NULL.

   215  
   216          *gpiod = gd;
   217          return 0;
   218  }

regards,
dan carpenter