Skip to contentSkip to conversation

drm/amdgpu/cgs: cleanup some indenting

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 4, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/cgs: cleanup some indenting

This code is indented too far. Also we normally use spaces to align if statement conditions.

drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +9 -9
index 6fa0fea..59485d0 100644
@@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
 	if (info->input_count > 0) {
 		if (info->pinput_argument = NULL)
 			return -EINVAL;
-			argument = info->pinput_argument;
-			func_no = argument->value;
-			for (i = 0; i < info->input_count; i++) {
-				if (((argument->type = ACPI_TYPE_STRING) ||
-					(argument->type = ACPI_TYPE_BUFFER))
-					&& (argument->pointer = NULL))
-					return -EINVAL;
-				argument++;
-			}
+		argument = info->pinput_argument;
+		func_no = argument->value;
+		for (i = 0; i < info->input_count; i++) {
+			if (((argument->type = ACPI_TYPE_STRING) ||
+			     (argument->type = ACPI_TYPE_BUFFER)) &&
+			    (argument->pointer = NULL))
+				return -EINVAL;
+			argument++;
+		}
 	}
 
 	if (info->output_count > 0) {
Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

This code is indented too far. Also we normally use spaces to align if statement conditions.

Applied. thanks!

Alex

Quoted 34 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +9 -9
index 6fa0fea..59485d0 100644
@@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
        if (info->input_count > 0) {
                if (info->pinput_argument = NULL)
                        return -EINVAL;
-                       argument = info->pinput_argument;
-                       func_no = argument->value;
-                       for (i = 0; i < info->input_count; i++) {
-                               if (((argument->type = ACPI_TYPE_STRING) ||
-                                       (argument->type = ACPI_TYPE_BUFFER))
-                                       && (argument->pointer = NULL))
-                                       return -EINVAL;
-                               argument++;
-                       }
+               argument = info->pinput_argument;
+               func_no = argument->value;
+               for (i = 0; i < info->input_count; i++) {
+                       if (((argument->type = ACPI_TYPE_STRING) ||
+                            (argument->type = ACPI_TYPE_BUFFER)) &&
+                           (argument->pointer = NULL))
+                               return -EINVAL;
+                       argument++;
+               }
        }
 
        if (info->output_count > 0) {

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel