fsl/fman: fix the pause_time test

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 6, 2016

Subsystems (4)

Networking Network drivers Kernel janitors Freescale QorIQ DPAA fman driver

lore

Share & tools

lore

Dan Carpenter

author

2016-01-06 09:58 UTC #0 lore raw

PATCH 1/1 fsl/fman: fix the pause_time test

pause_time is unsigned so it can't be less than zero. The bug means that we allow invalid pause-times.

Fixes 57ba4c9b56d8 ('fsl/fman: Add FMan MAC support')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/freescale/fman/fman_dtsec.c +1 -1

index d78e2ba..587f9b4 100644
@@ -934,7 +934,7 @@ int dtsec_set_tx_pause_frames(struct fman_mac *dtsec,
 
 	/* FM_BAD_TX_TS_IN_B_2_B_ERRATA_DTSEC_A003 Errata workaround */
 	if (dtsec->fm_rev_info.major = 2)
-		if (pause_time < 0 && pause_time <= 320) {
+		if (pause_time <= 320) {
 			pr_warn("pause-time: %d illegal.Should be > 320\n",
 				pause_time);
 			return -EINVAL;

David Miller

maintainer Applied

2016-01-06 20:28 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 6 Jan 2016 12:58:09 +0300

Quoted 5 lines

pause_time is unsigned so it can't be less than zero. The bug means that we allow invalid pause-times.
Fixes 57ba4c9b56d8 ('fsl/fman: Add FMan MAC support')
Signed-off-by Dan Carpenter <[email protected]>

Applied.