fsl/fman: double free on probe failure

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 6, 2016

Subsystems (4)

Networking Network drivers Kernel janitors Freescale QorIQ DPAA fman driver

lore

Share & tools

lore

Dan Carpenter

author

2016-01-06 09:59 UTC #0 lore raw

PATCH 1/1 fsl/fman: double free on probe failure

"priv" is allocated with devm_kzalloc() so freeing it here with kfree() will lead to a double free.

Fixes 3933961682a3 ('fsl/fman: Add FMan MAC driver')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/freescale/fman/mac.c +0 -1

index 743a393..e33d9d2 100644
@@ -961,7 +961,6 @@ _return_of_node_put:
 	of_node_put(dev_node);
 _return_dev_set_drvdata:
 	kfree(priv->fixed_link);
-	kfree(priv);
 	dev_set_drvdata(dev, NULL);
 _return:
 	return err;

David Miller

maintainer Applied

2016-01-06 20:28 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 6 Jan 2016 12:59:10 +0300

Quoted 5 lines

"priv" is allocated with devm_kzalloc() so freeing it here with kfree() will lead to a double free.
Fixes 3933961682a3 ('fsl/fman: Add FMan MAC driver')
Signed-off-by Dan Carpenter <[email protected]>

Applied.