vpx3220: signedness bug in vpx3220_fp_read()

PATCH New Dan Carpenter 1 participant 1 message Jan 6, 2016

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-01-06 10:05 UTC #0 lore raw

PATCH 1/1 vpx3220: signedness bug in vpx3220_fp_read()

The intent was to return -1 on error and that's what the callers expect but the current code returns USHRT_MAX instead.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/i2c/vpx3220.c +1 -1

index 4b564f1..90b693f 100644
@@ -124,7 +124,7 @@ static int vpx3220_fp_write(struct v4l2_subdev *sd, u8 fpaddr, u16 data)
 	return 0;
 }
 
-static u16 vpx3220_fp_read(struct v4l2_subdev *sd, u16 fpaddr)
+static int vpx3220_fp_read(struct v4l2_subdev *sd, u16 fpaddr)
 {
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
 	s16 data;