Skip to contentSkip to conversation

irda: toim3232-sir: delete some dead code

PATCH In review Dan Carpenter 2 participants 2 messages Jan 8, 2016

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 irda: toim3232-sir: delete some dead code

I noticed this code because it has a typo in the module_param(), the "trs" at the end of "toim3232fliptrs" should be "rts". But it's dead code so instead of fixing it, I just deleted it.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/irda/toim3232-sir.c +0 -10
index 6d2f559..b977d6d 100644
@@ -130,16 +130,6 @@ static int toim3232delay = 150;	/* default is 150 ms */
 module_param(toim3232delay, int, 0);
 MODULE_PARM_DESC(toim3232delay, "toim3232 dongle write complete delay");
 
-#if 0
-static int toim3232flipdtr = 0;	/* default is DTR high to reset */
-module_param(toim3232flipdtr, int, 0);
-MODULE_PARM_DESC(toim3232flipdtr, "toim3232 dongle invert DTR (Reset)");
-
-static int toim3232fliprts = 0;	/* default is RTS high for baud change */
-module_param(toim3232fliptrs, int, 0);
-MODULE_PARM_DESC(toim3232fliprts, "toim3232 dongle invert RTS (BR/D)");
-#endif
-
 static int toim3232_open(struct sir_dev *);
 static int toim3232_close(struct sir_dev *);
 static int toim3232_change_speed(struct sir_dev *, unsigned);
maintainer
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Fri, 8 Jan 2016 14:04:04 +0300

Quoted 5 lines

I noticed this code because it has a typo in the module_param(), the "trs" at the end of "toim3232fliptrs" should be "rts". But it's dead code so instead of fixing it, I just deleted it.

Signed-off-by Dan Carpenter <[email protected]>

Also applied, thanks Dan.