drm/nouveau/pci: reversed condition in nvkm_pcie_set_link()
Subsystems (4)
PATCH 1/1 drm/nouveau/pci: reversed condition in nvkm_pcie_set_link()
The condition is reversed so this function is a no-op.
drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c +1 -1
@@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)struct pci_bus *pbus;int ret; -if (pci || !pci_is_pcie (pci->pdev)) +if (!pci || !pci_is_pcie (pci->pdev))return 0 ; pbus = pci->pdev->bus;
Hi Dan,
yeah I also catched that. I assume something went wrong in the review process, because I am sure I didn't added that "pci ||" check myself ;) but who knows, maybe I was tired working with ben on that, cause it was like 4am while doing the last polishing steps.
nvm, I already send a patch to the nouveau ML:
http://lists.freedesktop.org/archives/nouveau/2016-January/023772.html
I just tried to poke ben the last day like several times, but he didn't seem to be there yesterday
Quoted 25 lines
Dan Carpenter <[email protected]> hat am 13. Januar 2016 um 13:21 geschrieben:
The condition is reversed so this function is a no-op.
Fixes bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speedchange')
Signed-off-by Dan Carpenter <[email protected]>drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c +1
-1@@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)struct pci_bus *pbus;int ret; -if (pci || !pci_is_pcie (pci->pdev)) +if (!pci || !pci_is_pcie (pci->pdev))return 0 ; pbus = pci->pdev->bus;
Quoted 8 lines
Karol Herbst <[email protected]> hat am 13. Januar 2016 um 13:30 geschrieben:
Hi Dan,
yeah I also catched that. I assume something went wrong in the review process, because I am sure I didn't added that "pci ||" check myself ;) but who knows, maybe I was tired working with ben on that, cause it was like 4am while doing
maybe I chose the wrong words here. Seems like I still need to improve my english here and there ;)
I meant that I was literally tired, cause it was 4am, not that I was tired because of ben. Just clarify that before somebody thinks I am a mean person.
Quoted 34 lines
the last polishing steps.
nvm, I already send a patch to the nouveau ML:
http://lists.freedesktop.org/archives/nouveau/2016-January/023772.htmlI just tried to poke ben the last day like several times, but he didn't seem to
be there yesterdayQuoted 25 lines
Dan Carpenter <[email protected]> hat am 13. Januar 2016 um 13:21 geschrieben:
The condition is reversed so this function is a no-op.
Fixes bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speedchange')
Signed-off-by Dan Carpenter <[email protected]>drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c +1
-1@@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)struct pci_bus *pbus;int ret; -if (pci || !pci_is_pcie (pci->pdev)) +if (!pci || !pci_is_pcie (pci->pdev))return 0 ; pbus = pci->pdev->bus;