Skip to contentSkip to conversation

PNPACPI: add support for HP vendor-specific CCSR descriptors

DISCUSSION Dan Carpenter 1 participant 1 message Jan 25, 2016 ACPI

lore
Share & tools
lore
#0 lore raw

Hello Bjorn Helgaas,

The patch 40ab4f4c1d84: "PNPACPI: add support for HP vendor-specific CCSR descriptors" from Jun 27, 2008, leads to the following static checker warning:

	drivers/pnp/pnpacpi/rsparser.c:170 pnpacpi_parse_allocated_vendor()
	error: __memcpy() 'vendor->byte_data' too small (1 vs 8)

drivers/pnp/pnpacpi/rsparser.c
164 static void pnpacpi_parse_allocated_vendor(struct pnp_dev *dev,
165 struct acpi_resource_vendor_typed *vendor)
166 {
167 if (vendor_resource_matches(dev, vendor, &hp_ccsr_uuid, 16)) {
168 u64 start, length;
169

   170                  memcpy(&start, vendor->byte_data, sizeof(start));
                                       ^^^^^^^^^^^^^^^^^

This is only 1 byte follow by 7 bytes of data we didn't want.

   171                  memcpy(&length, vendor->byte_data + 8, sizeof(length));
   172  
   173                  pnp_add_mem_resource(dev, start, start + length - 1, 0);
   174          }
   175  }

regards,
dan carpenter